allow link_with and link_whole to accept empty strings as a broken feature #15411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have two different uses where `''` used to be accepted because of python truthiness, but never should have been. This allows us to easily replace that value.
This is how it was treated < 1.10, and we should maintain that compatibility. I've added a converter function that repalces `['']` with `[]`. I don't entirely love this solution, but there are issues with other approaches. If we drop the call to listify, then we give up the ability to have nested lists, or we have to accept object and hand roll all of the validation. I don't really want to do either of those, and I think it's incredibly unlikley that anyone will pass `['']` to link_args, as they'd end up with the same build error reported in the issue. Fixes: mesonbuild#15376
Which has the same empty string issue.
dcbaker
force-pushed
the
submit/link-with-empty-string-behavior
branch
from
449776d to
99d8176
Compare
…ring values
This was reported as breaking pandas. Just like the `link_args`
behavior, this wasn't intended, but is a result of a leaky Python
abstraction ('' is falsy, and thus being caught in a falsy comparison,
such as `if not value: ...`).
This marks link_with and link_whole as being broken in the same way. I
have only marked this for build_targets, as I don't think it applies
elsewhere.
dcbaker
force-pushed
the
submit/link-with-empty-string-behavior
branch
from
99d8176 to
b059daa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15380
This regressed pandas in the master branch, so we should continue to allow this, but with a warning that will hopefully help others.