Commit 449776d
committed
interpreter/type_checking: fix link_with and link_whole with empty string values
This was reported as breaking pandas. Just like the `link_args`
behavior, this wasn't intended, but is a result of a leaky Python
abstraction ('' is falsy, and thus being caught in a falsy comparison,
such as `if not value: ...`).
This marks link_with and link_whole as being broken in the same way. I
have only marked this for build_targets, as I don't think it applies
elsewhere.1 parent dc96996 commit 449776d
1 file changed
+7
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
473 | 473 | | |
474 | 474 | | |
475 | 475 | | |
476 | | - | |
| 476 | + | |
477 | 477 | | |
478 | 478 | | |
479 | 479 | | |
| |||
748 | 748 | | |
749 | 749 | | |
750 | 750 | | |
751 | | - | |
752 | | - | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
753 | 757 | | |
754 | 758 | | |
755 | 759 | | |
| |||
0 commit comments