Skip to content

Test commit for XEdDSA support #7602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jp-bennett wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Test commit for XEdDSA support #7602

jp-bennett wants to merge 10 commits into from
+280 −105

Conversation

@jp-bennett
Copy link
Collaborator

@jp-bennett jp-bennett commented Aug 11, 2025

Very early preview of working XEdDSA packet signing.

@jp-bennett jp-bennett added enhancement New feature or request high-priority Issues that affect core functionality or are "show stoppers" bugfix Pull request that fixes bugs labels Aug 11, 2025
@lkosson
Copy link

lkosson commented Aug 12, 2025

With each subsequent NodeInfo update requiring a proper signature, wouldn't this feature require #5007 to be deployed as well? Without it, resetting a node to factory defaults and/or regenerating a key pair will not only prevent DMs as in abovementioned discussion, but also block changes to shortName / longName, forcing user to use old (semi-broken) identity.

@jp-bennett
Copy link
Collaborator Author

jp-bennett commented Aug 12, 2025

With each subsequent NodeInfo update requiring a proper signature, wouldn't this feature require #5007 to be deployed as well? Without it, resetting a node to factory defaults and/or regenerating a key pair will not only prevent DMs as in abovementioned discussion, but also block changes to shortName / longName, forcing user to use old (semi-broken) identity.

I think we have a good opportunity to do exactly this: Make the public Key the new primary identifier.

jp-bennett and others added 3 commits August 13, 2025 15:39
@jp-bennett
Update to Crypto lib in Meshtatic org
1dfad22
@jp-bennett
Merge branch 'master' into XEdDSA
359338d
@thebentern
Generate a new node identity on key generation (#7628)
c5c634e 
* Generate a new node identity on key generation

* Fixes

* Fixes

* Fixes

* Messed up

* Fixes

* Update src/modules/AdminModule.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/mesh/NodeDB.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Figured it out!

* Cleanup

* Update src/mesh/NodeDB.h

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/mesh/NodeDB.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/modules/AdminModule.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jp-bennett
Copy link
Collaborator Author

jp-bennett commented Aug 15, 2025 •
edited
Loading

TODO: make sure the packetID is included in the signature, and verified on receive
or use the first half of the signature as the source of the currently randomized portion of the packetID?

@jp-bennett jp-bennett changed the base branch from master to develop August 21, 2025 13:53
@github-actions github-actions bot added the Stale Issues that will be closed if not triaged. label Oct 13, 2025
@github-actions github-actions bot closed this Oct 22, 2025
@thebentern thebentern reopened this Oct 22, 2025
@thebentern thebentern added triaged Reviewed by the team, has enough information and ready to work on now. and removed Stale Issues that will be closed if not triaged. labels Oct 22, 2025
@jp-bennett jp-bennett mentioned this pull request Feb 11, 2026
Closed
@weebl2000
Copy link
Contributor

weebl2000 commented Feb 11, 2026

A total of 66 bytes per message seems like way too much imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix Pull request that fixes bugs enhancement New feature or request high-priority Issues that affect core functionality or are "show stoppers" triaged Reviewed by the team, has enough information and ready to work on now.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jp-bennett @lkosson @weebl2000 @thebentern