Generate a new node identity on key generation #7628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates duplicate cryptographic key generation logic into a centralized function and adds functionality to generate a new node identity when keys are regenerated. The changes improve code maintainability by eliminating redundant key generation code across multiple modules and ensure proper node identity management when cryptographic keys change.
- Consolidates duplicate key generation logic into
NodeDB::generateCryptoKeyPair() - Adds new identity creation functionality with
NodeDB::createNewIdentity() - Updates AdminModule and MenuHandler to use the centralized key generation function
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/modules/AdminModule.cpp | Replaces duplicate key generation logic with calls to centralized function and updates segment change flags |
| src/mesh/NodeDB.h | Adds declarations for new consolidated key generation and identity creation functions |
| src/mesh/NodeDB.cpp | Implements consolidated key generation logic and new identity creation functionality |
| src/graphics/draw/MenuHandler.cpp | Replaces duplicate key generation code with call to centralized function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.