Skip to content

Increase timeout for dput publish steps to 45 minutes - #12140

Merged
vidplace7 merged 1 commit into
developfrom
ppa-timeout
Oct 12, 2026
Merged

vidplace7 merged 1 commit into
developfrom
ppa-timeout

Conversation

@vidplace7

@vidplace7 vidplace7 commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

dput PPA upload operations began showing their status properly after #11941, revealing that many uploads are reaching ~85% and then timing out. This change increases the timeout for dput publish steps to prevent these failures.

Summary by CodeRabbit

  • Chores
    • Increased the time allowed for Launchpad package publishing attempts from 30 to 45 minutes.

`dput` PPA upload operations began showing their status properly after #11941, revealing that many uploads are reaching ~85% and then timing out.
This change increases the timeout for dput publish steps to prevent these failures.
@vidplace7 vidplace7 added linux-native related to running meshtastic as daemon on native linux github_actions Pull requests that update GitHub Actions code labels Oct 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: meshtastic/firmware/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: de2df2de-d665-427c-9e84-229728e74265

📥 Commits

Reviewing files that changed from the base of the PR and between e75d85f and 1f67edb.


📒 Files selected for processing (1)
  • .github/workflows/package_ppa.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.



📝 Walkthrough

Walkthrough

The workflow increases the timeout for the initial Launchpad SFTP publish step and its retry from 30 to 45 minutes. The retry condition and publishing command are unchanged.

Changes

Launchpad SFTP publishing

Layer / File(s) Summary
SFTP publish timeouts
.github/workflows/package_ppa.yml
The initial SFTP publish step and its retry now have 45-minute timeouts.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix


Merge Risk: ⚪ Minimal · up to 1f67e

The initial upload and retry can each run for up to 45 minutes, addressing the reported timeout issue. No checked-in shorter job limit undermines the change.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check Warning The description explains the timeout failures and the intended fix, but it does not follow the repository template. It omits the required testing attestations and related testing details. Add the required template sections, including the PR summary and testing attestations. State whether the workflow change was tested and identify any unavailable hardware or regression testing limits.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: increasing the dput publish-step timeout to 45 minutes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vidplace7
vidplace7 enabled auto-merge October 12, 2026 16:26
@vidplace7
vidplace7 added this pull request to the merge queue Oct 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

MemBrowse Memory Report

heltec-mesh-node-t114

  • FLASH: .text -16 B (-0.0%, 718,228 B / 802,816 B, total: 89% used)

rak4631

  • FLASH: .text +8 B (+0.0%, 711,820 B / 802,816 B, total: 89% used)

seeed_wio_tracker_L1

  • FLASH: .text -16 B (-0.0%, 708,348 B / 798,720 B, total: 89% used)

t-echo-plus

Merged via the queue into develop with commit 8e4ccb0 Oct 12, 2026
99 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code linux-native related to running meshtastic as daemon on native linux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant