-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#55 Update multiple fields in indicate_errors #191
Conversation
@jwallwork23 I didn't want to do this on your 55_multiple_var_ee branch. I left it to you to delete :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Why did you cancel the CI? Please trigger it so that we can check the tests pass.
Because tests fail anyway since the docker image doesn't have the |
I've rebuild the Docker image, will trigger tests now. |
Hm, there seems to be a problem with |
Thanks Joe! Everything passed for me yesterday after updating firedrake on Monday, but I updated it again now and get the same tests failing. Sorry about that. |
@jwallwork23 @ddundo - I am getting an error with It looks like a PR has been added in Firedrake to address this: firedrakeproject/firedrake#3557 |
Thanks for looking into this anyway @acse-ej321 :) |
@jwallwork23 - It appears the fix for this has been merged into firedrake |
And again. Now fixed. Ready for merge if you're happy @ddundo |
Thanks both! |
Closes #55.
@acse-ej321 could you please take a look as well? I'm not confident how clear the long comment block is, so I'd appreciate a fresh set of eyes to take a look, since Joe and I are already familiar with the issue :)