Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need to stop relying on comm=None #3557

Merged
merged 1 commit into from
May 9, 2024
Merged

We need to stop relying on comm=None #3557

merged 1 commit into from
May 9, 2024

Conversation

JDBetteridge
Copy link
Member

Description

@pefarrell
Copy link
Contributor

I think for user-facing things it makes sense to default comm to COMM_WORLD. But I think that for developer-facing things (like load) we should demand that a comm be passed.

@JDBetteridge
Copy link
Member Author

I agree, to clarify my comment a bit: I think we should stop relying on the comm=None defaulting to COMM_WORLD internally. I don't have plans to force users to have to specify an MPI communicator for all of their scripts. However, internally relying on this behaviour makes it hard to track down parallel bugs!

@acse-ej321 acse-ej321 mentioned this pull request May 9, 2024
Merged
connorjward
connorjward approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JDBetteridge JDBetteridge merged commit 06bea4f into master May 9, 2024
9 of 10 checks passed
@JDBetteridge JDBetteridge deleted the JDBetteridge/pyop2_quickfix branch May 9, 2024 14:47
juliusgh pushed a commit to juliusgh/firedrake that referenced this pull request May 13, 2024
@JDBetteridge @juliusgh
We need to stop internally relying on comm=None (firedrakeproject#3557)
0858e9f
Ig-dolci pushed a commit that referenced this pull request Jul 6, 2024
@JDBetteridge @Ig-dolci
We need to stop internally relying on comm=None (#3557)
4377e79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- left review comments

@connorjward connorjward connorjward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JDBetteridge @pefarrell @wence- @connorjward