-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/merges #30
Merged
Merged
Feature/merges #30
Changes from 3 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
01a3f69
Add Header
hamidazim321 c02c492
Update with footer
mershark 0ac0109
Create display list
mershark bc27793
Update with style
mershark 9674491
Correct lint error
mershark 929bc46
Fix Linter Errors
hamidazim321 16ecbcb
Fix Eslint errors
hamidazim321 b39fc43
Merge pull request #22 from mershark/feature/display-meal
mershark 18d20e0
add function to post and get comments from the api
hamidazim321 bff2a9a
Add function to create and populate popups
hamidazim321 74d36b6
add function to post comments
hamidazim321 db83f68
add comments counter
hamidazim321 c2a4e59
Fix eslint errors
hamidazim321 3c2e165
Fix Stylelint errors
hamidazim321 62ce965
Relocate the footer to the bottom of the page
hamidazim321 1c747f4
Merge pull request #23 from mershark/feature/comments
hamidazim321 77b4b21
Update with add function to display likes
mershark acdcb12
Fix linter errors
hamidazim321 d8eeece
Merge pull request #24 from mershark/features/like
mershark 8ae53f7
add jsdom
hamidazim321 0ec6303
Add tests for the comments Counter Function
hamidazim321 9767259
Fix Linter errors
hamidazim321 ea994af
Merge pull request #27 from mershark/feature/test1
hamidazim321 2acd8ba
Create test2
mershark a743e2d
Fix Linter Errors
hamidazim321 7405266
Merge pull request #28 from mershark/feature/test2
mershark 326c21a
Add final styles
hamidazim321 562c369
Fix Linter errors
hamidazim321 222803c
Merge pull request #29 from mershark/feature/finalTouches
hamidazim321 ce04b2e
Update README.md
mershark 7e53e9c
Create MIT.md
mershark 949a11a
Update the dist folder
hamidazim321 91703f6
Merge branch 'feature/merges' of github.com:mershark/Microverse-capst…
hamidazim321 72afdc5
Relocate the Counter functions into separate modules aand update the …
hamidazim321 869a987
Update Imports
hamidazim321 001b421
Update dist folder and fix linter errors
hamidazim321 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly also test for the case when there are no meals on the home screen like you tested for the comments. As per the project requirements, tests should cover all the edge cases.