Feature/merges #30
Feature/merges #30
Conversation
Display Meals
Feature/comments
Display likes
Feature/test1
Add final styles
…one-2 into feature/merges
There was a problem hiding this comment.
Hi team,
Good job so far! I see you put a lot of effort into this project. However, there are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- No linter errors
- Descriptive PR
- Followed template design
- Used involvement API
- Split code in proper modules.
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| describe('Meals Counter', () => { | ||
| test('Update Header to have the correct Count of Items', () => { |
There was a problem hiding this comment.
Kindly also test for the case when there are no meals on the home screen like you tested for the comments. As per the project requirements, tests should cover all the edge cases.
src/Modules/counter.js
Outdated
| const mealCounter = (arr) => { | ||
| const navDishes = document.querySelector('#nav-dishes'); | ||
| navDishes.textContent += ` (${arr.length})`; | ||
| }; | ||
|
|
||
| const commentsCounter = (arr, header) => { | ||
| if (Array.isArray(arr)) { | ||
| header.textContent = `Comments (${arr.length})`; | ||
| } else { | ||
| header.textContent = 'Comments (0)'; | ||
| } | ||
| }; | ||
| export { mealCounter, commentsCounter }; |
There was a problem hiding this comment.
One of the project requirements is that each counter should be implemented as a separate module. Kindly move each of these counters into a separate file.
There was a problem hiding this comment.
Hi @mershark , @muneebulrehman ,
APPROVED 🟢
Highlights
- Innovative idea in a good-looking website ✔️
- good UI design ✔️
- no linter errors ✔️
- correct github flow is used ✔️
- good PR description ✔️
Great implementation of all the requirements in this milestone. 👏
You have done an amazing job 👍
Your project is complete! There is nothing else to say other than... it's time to merge it. 
Congratulations! 🎉
CHEERS AND HAPPY CODING!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this project together with my partner @hamidazim321 we created a fully functional meal webpage. Some of the things we implemented in this task are:
Changes after the previous review
We have added all the features required by the reviewer