Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocking of clock in gantt tests #1536

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Jul 12, 2020

📑 Summary

Makign sure the date is mocket in the rendering tests of gantt diagram. This will avoid generating false positivs every day when the date changes.
Resolves #1448

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@knsv knsv merged commit b40014d into develop Jul 12, 2020
@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jul 12, 2020
@GDFaber
Copy link
Member

GDFaber commented Jul 12, 2020

That's cool, thanks. When I wrote the test I didn't think about the changing dates but this should take care of the matter.

@mmorel-35 mmorel-35 deleted the bug/1448_mock_clock_in_render_tests branch December 15, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mock the date in the rendering tests of the today marker for the gantt chart
2 participants