Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock the date in the rendering tests of the today marker for the gantt chart #1448

Closed
knsv opened this issue Jun 6, 2020 · 0 comments · Fixed by #1536
Closed

Mock the date in the rendering tests of the today marker for the gantt chart #1448

knsv opened this issue Jun 6, 2020 · 0 comments · Fixed by #1536
Assignees
@knsv
Labels
Area: Development Graph: Gantt Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@knsv
Copy link
Collaborator

knsv commented Jun 6, 2020

As the date changes the rendering tests constantly picks up changes in the gantt diagram that needs to be verified manually.

Instead:
The date should be mocked in the cypress test so that the date never changes so that the flase positives stop.
@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Jun 6, 2020
@knsv knsv self-assigned this Jul 12, 2020
@knsv knsv mentioned this issue Jul 12, 2020
Merged
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@knsv knsv

Labels
Area: Development Graph: Gantt Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mocking of clock in gantt tests mermaid-js/mermaid
1 participant
@knsv