-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove direct Checkmarx adapter usage - provide only PDS adapter #1320
Labels
3rd-party-integration
checkmarx
data
enhancement
New feature or request
epic
pds
pds-solutions
server
Milestone
Comments
This was referenced May 9, 2022
This was referenced Jun 22, 2022
Decided to use Variant A. But we do this in three steps.
|
de-jcup
added
pds
pds-solutions
enhancement
New feature or request
3rd-party-integration
labels
Jun 22, 2022
de-jcup
changed the title
Checkmarx product executor must handle data section
Remove direct Checkmarx adapter usage - provide only PDS adapter
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd-party-integration
checkmarx
data
enhancement
New feature or request
epic
pds
pds-solutions
server
Situation
With
we created a possiblity to define source code data inside the
codeScan
element but also inside the new data section.As described in #1313 the architve structure does contain
__data__/$referenceName
.Currently the Checkmarx product executor will send the created zip content without any further treatment to checkmarx.
The problem here: It will contain
__data__/$referenceName
and use this as the reference pathes inside its findings!So e.g. when using sechub plugins to open a finding the path would not be correct. Also reading checkmarx findings inside
HTML reports would be difficult.
Wanted
Checkmarx adapter shall send a ZIP file which does not contain data section pathes inside
Solution
There are two possible solutions
Variant A
We move the Checkmarx product adapter to a PDS solution. This will use #1319 automatically and only necessary stuff will be inside the zip file.
Variant B
The mechanism inside
sourcecode.zip
with data section parts on PDS server side #1319will be written in a very reusable way and is also available inside SecHub server (via library). Then the checkmarx product executor will
checkmarx product adapter.
Additional
For #1164 only PDS does support the filtering.
When we use Variant B we must also introduce
sechub.productexecutor.filefilter.excludes
andsechub.productexecutor.filefilter.includes
to handle this on sechub side as well. This will done by #1395The text was updated successfully, but these errors were encountered: