Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDS: Handle binaries.tar with data secion parts on PDS server side #1167

Closed
de-jcup opened this issue Mar 28, 2022 · 0 comments · Fixed by #1316
Closed

PDS: Handle binaries.tar with data secion parts on PDS server side #1167

de-jcup opened this issue Mar 28, 2022 · 0 comments · Fixed by #1316
Assignees
@de-jcup
Labels
binary data pds storage
Milestone
PDS 0.29.0

Comments

@de-jcup
Copy link
Member

de-jcup commented Mar 28, 2022 •
edited
Loading

Situation

With ...

But currently the PDS does not handle binaries at all

Wanted

The PDS shall ...

Solution
@de-jcup de-jcup added the epic label Mar 28, 2022
@de-jcup de-jcup mentioned this issue Mar 28, 2022
Closed
@de-jcup de-jcup removed the epic label Mar 29, 2022
@de-jcup de-jcup changed the title Epic: Binary upload Binary upload Mar 29, 2022
@de-jcup de-jcup changed the title Binary upload Enhance file structure inside ZIP (and TAR) to handle data section Mar 29, 2022
@de-jcup de-jcup added the pds label Mar 29, 2022
@de-jcup de-jcup modified the milestones: Server 0.30.0, PDS 0.27.0 Mar 29, 2022
@de-jcup de-jcup changed the title Enhance file structure inside ZIP (and TAR) to handle data section PDS: Handle binary.tar Mar 29, 2022
@de-jcup de-jcup added the binary label Mar 29, 2022
@sven-dmlr sven-dmlr modified the milestones: PDS 0.27.0, PDS 0.28.0 Apr 7, 2022
@de-jcup de-jcup changed the title PDS: Handle binary.tar PDS: Handle binaries.tar Apr 11, 2022
@de-jcup de-jcup changed the title PDS: Handle binaries.tar PDS: Handle binaries.tar on PDS server side May 2, 2022
@de-jcup de-jcup mentioned this issue May 2, 2022
Closed
@de-jcup de-jcup self-assigned this May 6, 2022
de-jcup added a commit that referenced this issue May 6, 2022
@de-jcup
Start implementing support for binaries on PDS side #1167
5f9ff7a 
- Introduce apache commons compress library for tar archives # 1167
- implementing PDSTarSupport which archive inspection and filtering
  inclusive path transformation
@de-jcup de-jcup mentioned this issue May 6, 2022
Merged
@de-jcup de-jcup changed the title PDS: Handle binaries.tar on PDS server side PDS: Handle binaries.tar with data secion parts on PDS server side May 9, 2022
@de-jcup de-jcup mentioned this issue May 9, 2022
Closed
de-jcup added a commit that referenced this issue May 9, 2022
@de-jcup
Moved gradle sub parts to gradle folder #1321 + introduce archive
4403785 
- all gradle sub files from rootfolder are now moved
  to `gradle` subfolder
- introduced `sechub-commons-archive` gradle submodule for handling
  issues #1320, #1319 and #1167
de-jcup added a commit that referenced this issue May 9, 2022
@de-jcup
Replaced PDSScanType with ScanType #1322,consolidate archive parts #1323
e207666 


- replaced PDSScanType with ScanType
- moved new and old archive parts for #1167 to
  sechub-commons-archive
@de-jcup de-jcup mentioned this issue May 11, 2022
Closed
de-jcup added a commit that referenced this issue May 11, 2022
@de-jcup
Implemented transformation while extracting ZIP and Tars #1167
f34d4c0 
- implemented transformation while extracting
  same logic used for TAR and ZIP
- some refactoring/renaming
- simplified some parts
- added tests
@sven-dmlr sven-dmlr modified the milestones: PDS 0.28.0, PDS 0.29.0 May 11, 2022
de-jcup added a commit that referenced this issue May 13, 2022
@de-jcup
Implemented transformation while extracting ZIP and Tars #1167
e7f99c1 
- implemented transformation while extracting
  same logic used for TAR and ZIP
- some refactoring/renaming
- simplified some parts
- added tests
- added special logging for sechub client execution on
  integration tests: elapsed time is now calculated and shown
de-jcup added a commit that referenced this issue May 19, 2022
@de-jcup
Created javadoc overview and details about profiles for testing #1167
ab078f4 
- for the integration tests for binary scans with PDS it was necessary
  to have a better overview of the current profiles and test scenarios
de-jcup added a commit that referenced this issue May 19, 2022
@de-jcup
Implemented integration test for binary PDS handling #1167
55b70f1
de-jcup added a commit that referenced this issue May 19, 2022
@de-jcup
Implementation changes for #1167
c0f208d 
- refactored adapter config strategies,
  introduced two interfaces without generics, simplifed much
- Every PDS executor does now use the PDSAdapterConfigurationStrategy
  so we have one central configuration option for all common PDS parts
- The integration tests fails because green is returned, but no longer
  execution exceptions
de-jcup added a commit that referenced this issue May 21, 2022
@de-jcup
Implementation changes for #1167
ef49e51 
- to avoid implementing always same builder logic for every PDS
  adapter a refactoring was done:

  - PDSAdapterConfigData is contained
  by every PDSAdapterConfig variant. PDS relevant config data is stored
  there now.

  - PDSAdapterConfiguratoris also contained now in every pds adapter
    config variant and is used for configuration by common
    PDSAdapterConfigurationStrategy

  - The data and the configuration is implemented in one class:
    PDSAdapterDataConfigurator
 - documented PDS adapter configuration in architecture concepts
de-jcup added a commit that referenced this issue May 25, 2022
@de-jcup
Added integration tests + updated documentation #1167
ce33e7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
binary data pds storage
Projects
None yet
Milestone
PDS 0.29.0
Development

Successfully merging a pull request may close this issue.

Handle binaries and sourcecode data section parts at PDS and SecHub side mercedes-benz/sechub
2 participants
@de-jcup @sven-dmlr