This repository has been archived by the owner on Oct 27, 2020. It is now read-only.
Added the possibility to specify which mmdb to download during composer install #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mente
approved these changes
Feb 11, 2017
composer.json
Outdated
| @@ -32,6 +37,7 @@ | |||
| }, | |||
| "minimum-stability": "stable", | |||
| "extra": { | |||
| "maxmind-db-path": "Tests/GeoLite2-Country.mmdb" | |||
| "maxmind-db-path": "app/geolite2.mmdb", | |||
There was a problem hiding this comment.
that's the problem of failed tests. app folder doesn't exist + bug in \Insomnia\MaxMindGeoIpBundle\Command\LoadDatabaseCommand (check 17dc4df for fix)
By default extra is ignored in root composer.json so it's safe to leave it as Tests/geolite2.mmdb
Closed
rvanlaak
added a commit
to rvanlaak/MaxMindGeoIpBundle
that referenced
this pull request
Feb 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed non-existing path