Skip to content
This repository has been archived by the owner on Oct 27, 2020. It is now read-only.

Configure file to download in config file #5

Closed
jaumebosch opened this issue Feb 3, 2017 · 10 comments
Closed

Configure file to download in config file #5

jaumebosch opened this issue Feb 3, 2017 · 10 comments

Comments

@jaumebosch
Copy link
Contributor

Would be nice to be able to specify which mmdb to download in the config.yml. Now is hardcoded to geolite2-country.mmdb

@mente
Copy link
Owner

mente commented Feb 4, 2017

Do you mean the one used by composer handler? Because for symfony command you're obliged to specify full url

@jaumebosch
Copy link
Contributor Author

yep, that's it.
In my case I don't want to add to git the full db, I managerd to automatically launch a composer install after deploy and download the mmdb in that moment.

BTW, I possible can do the pull request during the week

@mente
Copy link
Owner

mente commented Feb 6, 2017

PR would be great :). Please keep in mind that in composer handler it's not that easy to get access to symfony app and probably you need to define url in composer.json extras

@jaumebosch
Copy link
Contributor Author

you have a pull request, so quick and simply, but does the job

@jaumebosch
Copy link
Contributor Author

:/ just modifing some path doesn't pass the travis test, but it should

@jaumebosch
Copy link
Contributor Author

any clue?

@mente
Copy link
Owner

mente commented Feb 7, 2017

Check pull request, i gave comment there

@jaumebosch
Copy link
Contributor Author

I'm unable to see any comment on the pull request :/

@mente
Copy link
Owner

mente commented Feb 11, 2017

Closed via #6

@mente mente closed this as completed Feb 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants