Skip to content

#2175 review unit tests and add exclusion cause #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2025
Merged

#2175 review unit tests and add exclusion cause #2198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b349734
checkpoint
christiangoerdes Oct 7, 2025
d737ada
Improve test annotations and clarify reasons for disabling specific t…
christiangoerdes Oct 7, 2025
a015d99
Merge branch 'master' into #2175-review-UniTests
christiangoerdes Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 14 additions & 29 deletions core/src/test/java/com/predic8/membrane/core/UnitTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,42 +15,27 @@

import org.junit.platform.suite.api.*;

/**
* TODO Fix:
* - com.predic8.membrane.core.interceptor.opentelemetry.OpenTelemetryInterceptorTest
* - com.predic8.membrane.core.interceptor.rewrite.RewriteInterceptorIntegrationTest // Rewrite as UnitTest with sampleSOAPService
* Still in use?
* - com.predic8.membrane.core.interceptor.oauth2client.OAuth2Resource2InterceptorTest
* - com.predic8.membrane.core.interceptor.shadowing.ShadowingInterceptorTest
*/
@Suite
@SelectPackages({"com.predic8"})
@ExcludeClassNamePatterns({
"com.predic8.membrane.AllTests",
"com.predic8.membrane.core.interceptor.opentelemetry.OpenTelemetryInterceptorTest",
"com.predic8.membrane.core.interceptor.balancer.NodeOnlineCheckerTest",
"com.predic8.membrane.core.interceptor.tunnel.WebsocketStompTest",
"com.predic8.membrane.core.interceptor.oauth2client.OAuth2Resource2InterceptorTest",
"com.predic8.membrane.core.interceptor.shadowing.ShadowingInterceptorTest",
"com.predic8.membrane.core.interceptor.rewrite.RewriteInterceptorIntegrationTest",
//
// From includes, weren't run before!
// TODO: Fix or delete
"com.predic8.membrane.core.transport.http.ConnectionTest",
"com.predic8.membrane.core.util.MemcachedConnectorTest"

"com.predic8.membrane.AllTests", // Replaced with package scan
"com.predic8.membrane.core.transport.http.ConnectionTest", // #2180 should fix it
"com.predic8.membrane.core.interceptor.rewrite.RewriteInterceptorIntegrationTest", // Rewrite as UnitTest with sampleSOAPService
"com.predic8.membrane.core.interceptor.tunnel.WebsocketStompTest", // Fails: not standalone; depends on external WS+STOMP setup
"com.predic8.membrane.core.interceptor.oauth2client.OAuth2Resource2InterceptorTest", // Disabled: incomplete setup; AuthorizationService (and other) not configured
"com.predic8.membrane.core.util.MemcachedConnectorTest" // Disabled: not standalone; needs Memcached at 127.0.0.1:11211 (fails with Connection refused)
})
public class UnitTests {
/*
* Uncomment below to speed up test execution!
*
*/
/*
* @BeforeClass public static void forbidScreenOutput() { PrintStream ps =
* new PrintStream(new OutputStream() {
*
* @Override public void write(int b) throws IOException { throw new
* RuntimeException("this test uses stdout"); } }); System.setOut(ps);
* System.setErr(ps); }
*/
/*
* @BeforeClass public static void forbidScreenOutput() { PrintStream ps =
* new PrintStream(new OutputStream() {
*
* @Override public void write(int b) throws IOException { throw new
* RuntimeException("this test uses stdout"); } }); System.setOut(ps);
* System.setErr(ps); }
*/
}
2 changes: 1 addition & 1 deletion core/src/test/java/com/predic8/membrane/core/interceptor/tunnel/WebsocketStompTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
public class WebsocketStompTest {
@Test
public void testWebsocketStomp() throws Exception{
// Preparation: tart the Websocket-Stomp example from an external source
// Preparation: Start the Websocket-Stomp example from an external source

// Starts embedded ActiveMQ and places "Hello world!" into the "foo" queue
// Verification: If you open "localhost:4333" with running example the message appears -> Server part works
Expand Down
4 changes: 2 additions & 2 deletions distribution/examples/websockets/websocket-stomp/proxies.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

<serviceProxy port="4443">
<ssl>
<keystore location="../../conf/membrane.p12" password="secret" keyPassword="secret" />
<truststore location="../../conf/membrane.p12" password="secret" />
<keystore location="../../../conf/membrane.p12" password="secret" keyPassword="secret" />
<truststore location="../../../conf/membrane.p12" password="secret" />
</ssl>

<log />
Expand Down