#2175 review unit tests and add exclusion cause

[christiangoerdes]

Summary by CodeRabbit

• Bug Fixes

  • Corrected SSL keystore/truststore paths in the WebSocket STOMP example to ensure certificates load correctly and the example runs as expected.

• Documentation

  • Fixed a minor typo in a test comment.

• Tests

  • Simplified the unit test suite by updating the list of excluded tests, improving test execution focus without changing product behavior.

[coderabbitai]

Walkthrough

Updated test suite exclusions in UnitTests, corrected a comment typo in WebsocketStompTest, and adjusted SSL keystore/truststore relative paths in the websocket-stomp example configuration.

Changes

Cohort / File(s)	Summary
Test suite exclusions core/src/test/java/.../UnitTests.java	Replaced extensive exclusion list with a smaller set of ExcludeClassNamePatterns; removed outdated TODO comment; minor formatting adjustment in a commented block.
WebSocket STOMP test comment fix core/src/test/java/.../interceptor/tunnel/WebsocketStompTest.java	Fixed a comment typo (“tart” → “Start”); no logic changes.
WebSocket STOMP example SSL paths distribution/examples/websockets/websocket-stomp/proxies.xml	Updated SSL keystore/truststore paths from ../../conf/membrane.p12 to ../../../conf/membrane.p12.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• predic8
• rrayst

Poem

I thump my paw—tests neatly aligned,
Fewer skips now, exclusions refined.
A tiny typo hops away,
STOMP sings clearer today.
Keys and trust take a longer trail,
But paths now lead without fail.
Carrot-shaped builds, ready to sail! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title uses an issue number and vaguely refers to “review unit tests” and “add exclusion cause” without clearly summarizing the key change of updating the UnitTests exclusion patterns, and it does not reflect the minor SSL configuration update. It is not concise or descriptive enough for teammates scanning the commit history.	Please rewrite the title to directly describe the primary change, for example “Update UnitTests to exclude specific test classes” or “Refine UnitTests exclusion list,” omitting the issue number and using clear, descriptive language.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch #2175-review-UniTests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9dda259 and d737ada.

📒 Files selected for processing (3)

• core/src/test/java/com/predic8/membrane/core/UnitTests.java (1 hunks)
• core/src/test/java/com/predic8/membrane/core/interceptor/tunnel/WebsocketStompTest.java (1 hunks)
• distribution/examples/websockets/websocket-stomp/proxies.xml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (java)

🔇 Additional comments (3)

core/src/test/java/com/predic8/membrane/core/interceptor/tunnel/WebsocketStompTest.java (1)

26-26: LGTM! Typo corrected.

The comment typo has been fixed from "tart" to "Start".

core/src/test/java/com/predic8/membrane/core/UnitTests.java (2)

20-27: Excellent documentation of test exclusions.

The updated exclusion patterns now include clear, actionable reasons for why each test is excluded:

• ConnectionTest: tracked by issue #2180
• RewriteInterceptorIntegrationTest: needs refactoring
• WebsocketStompTest: not standalone (requires external infrastructure)
• OAuth2Resource2InterceptorTest: incomplete setup
• MemcachedConnectorTest: requires external Memcached service

This documentation significantly improves maintainability by making it clear which tests need attention and why.

---

33-40: LGTM! Minor formatting adjustment.

The formatting of the commented-out code block has been adjusted for consistency. No functional impact.

[membrane-ci-server]

This pull request needs "/ok-to-test" from an authorized committer.

[christiangoerdes]

/ok-to-test