-
Notifications
You must be signed in to change notification settings - Fork 140
update interceptor documentation #2173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. WalkthroughThis PR updates documentation and formatting only: Javadoc text tweaks in BeautifierInterceptor and IfInterceptor, and whitespace normalization in an annotation on HttpClientConfiguration. No code logic, behavior, control flow, or public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This pull request needs "/ok-to-test" from an authorized committer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
core/src/main/java/com/predic8/membrane/core/interceptor/beautifier/BeautifierInterceptor.java (1)
31-31
: Polish wording and casing for supported formats.Align with getShortDescription and avoid shouting “TEXT”.
- * @description Beautifies request and response bodies. Supported are the Formats: <b>JSON</b>, <b>JSON5</b>, <b>XML</b>, <b>TEXT</b> + * @description Beautifies request and response bodies. Supported formats: <b>JSON</b>, <b>JSON5</b>, <b>XML</b>, <b>text</b>.core/src/main/java/com/predic8/membrane/core/transport/http/client/HttpClientConfiguration.java (1)
27-47
: Clarify YAML example: maxRetries semantics.Add a brief note so users understand it’s “additional retries,” not total attempts.
- * <pre><code>httpClientConfig: - * maxRetries: 5 + * <pre><code>httpClientConfig: + * maxRetries: 5 # additional retries (total attempts = 6)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
core/src/main/java/com/predic8/membrane/core/interceptor/beautifier/BeautifierInterceptor.java
(1 hunks)core/src/main/java/com/predic8/membrane/core/interceptor/flow/IfInterceptor.java
(1 hunks)core/src/main/java/com/predic8/membrane/core/transport/http/client/HttpClientConfiguration.java
(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
core/src/main/java/com/predic8/membrane/core/transport/http/client/HttpClientConfiguration.java (3)
core/src/main/java/com/predic8/membrane/core/interceptor/HTTPClientInterceptor.java (1)
MCElement
(43-225)core/src/main/java/com/predic8/membrane/core/transport/http/client/RetryHandler.java (1)
MCElement
(51-320)core/src/main/java/com/predic8/membrane/core/interceptor/oauth2/authorizationservice/DynamicRegistration.java (1)
MCElement
(34-128)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (1)
core/src/main/java/com/predic8/membrane/core/transport/http/client/HttpClientConfiguration.java (1)
50-50
: Annotation whitespace tweak looks good.
Summary by CodeRabbit
No functional or behavioral changes.