-
Notifications
You must be signed in to change notification settings - Fork 140
update interceptor documentation #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation-only updates to Javadocs in three interceptors: wording and capitalization tweaks, plus an SpEL example and clarified parameter descriptions. No code, control-flow, or public API signature changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This pull request needs "/ok-to-test" from an authorized committer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (4)
core/src/main/java/com/predic8/membrane/core/interceptor/flow/ReturnInterceptor.java (2)
42-43
: Clarify “messages” and tighten phrasing.“messages” is ambiguous (request vs. response). Recommend explicitly stating which message(s) are overridden.
- * The options <i>statusCode</i> and <i>contentType</i> will overwrite the values from the messages. + * Options <i>statusCode</i> and <i>contentType</i> override values from the existing request/response messages.
138-141
: Prefer “Content-Type” for header naming consistency.Small editorial improvement for precision and consistency with HTTP terminology.
- * @description Content type of the response. If not set, the content type of the request (if available) or no content type will be used. + * @description Content-Type of the response. If not set, the request's Content-Type (if available) is used; otherwise, no Content-Type is set.core/src/main/java/com/predic8/membrane/core/interceptor/balancer/LoadBalancingInterceptor.java (1)
38-39
: Use code styling for element names and consistent casing.Minor readability polish: mark element names as code and use “an interceptor”.
- * @explanation May only be used as interceptor in a serviceProxy or api. + * @explanation May only be used as an interceptor in a <code>serviceProxy</code> or <code>api</code>.core/src/main/java/com/predic8/membrane/core/interceptor/flow/IfInterceptor.java (1)
116-118
: Optional: add period and code styling for identifiers.Minor editorial polish.
- * @description Condition to be tested - * @example <ul><li>request.isJSON()</li><li>params['limit'] >= 0</li><li>statusCode matches '[45]\d\d'</li></ul> + * @description Condition to be tested. + * @example <ul><li><code>request.isJSON()</code></li><li><code>params['limit'] >= 0</code></li><li><code>statusCode matches '[45]\d\d'</code></li></ul>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
core/src/main/java/com/predic8/membrane/core/interceptor/balancer/LoadBalancingInterceptor.java
(2 hunks)core/src/main/java/com/predic8/membrane/core/interceptor/flow/IfInterceptor.java
(3 hunks)core/src/main/java/com/predic8/membrane/core/interceptor/flow/ReturnInterceptor.java
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (2)
core/src/main/java/com/predic8/membrane/core/interceptor/flow/ReturnInterceptor.java (1)
124-127
: LGTM on statusCode description.core/src/main/java/com/predic8/membrane/core/interceptor/balancer/LoadBalancingInterceptor.java (1)
191-195
: LGTM on improved wording (“load balancer”).
Summary by CodeRabbit