refactor: Deprecate passing file paths to plugin and stream initialization #2743

edgarrmondragon · 2024-11-07T00:01:02Z

📚 Documentation preview 📚: https://meltano-sdk--2743.org.readthedocs.build/en/2743/

codspeed-hq · 2024-11-07T00:03:49Z

CodSpeed Performance Report

Merging #2743 will not alter performance

_{Comparing edgarrmondragon/refactor/deprecate-config-catalog-schema (208ccc7) with main (de7d1dc)}

Summary

✅ 6 untouched benchmarks

codecov · 2024-11-07T00:08:42Z

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (62c03bb) to head (208ccc7).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
singer_sdk/tap_base.py	50.00%	2 Missing ⚠️
singer_sdk/plugin_base.py	75.00%	1 Missing ⚠️
singer_sdk/streams/core.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2743      +/-   ##
==========================================
- Coverage   90.80%   90.74%   -0.07%     
==========================================
  Files          62       62              
  Lines        5089     5099      +10     
  Branches      658      658              
==========================================
+ Hits         4621     4627       +6     
- Misses        326      330       +4     
  Partials      142      142

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ation

…ation (#2743)

… schemas (#2566) * refactor: Standardize on JSON Schema Draft 2020-12 to validate stream schemas * chore(deps): bump pip from 24.2 to 24.3.1 in /.github/workflows in the ci group (#2733) chore(deps): bump pip in /.github/workflows in the ci group Bumps the ci group in /.github/workflows with 1 update: [pip](https://github.com/pypa/pip). Updates `pip` from 24.2 to 24.3.1 - [Changelog](https://github.com/pypa/pip/blob/main/NEWS.rst) - [Commits](pypa/pip@24.2...24.3.1) --- updated-dependencies: - dependency-name: pip dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ci ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test: Test `parquet` extra on Python 3.13 (#2734) * test: Test `parquet` extra on Python 3.13 * Remove xfails * chore: pre-commit autoupdate (#2735) * chore: pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.7.0 → v0.7.1](astral-sh/ruff-pre-commit@v0.7.0...v0.7.1) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * packaging: Skip `simpleeval` 1.0.1 (#2736) * chore(deps): bump pypa/gh-action-pypi-publish from 1.10.3 to 1.11.0 in the actions group (#2737) chore(deps): bump pypa/gh-action-pypi-publish in the actions group Bumps the actions group with 1 update: [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish). Updates `pypa/gh-action-pypi-publish` from 1.10.3 to 1.11.0 - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Run `poetry lock` (#2738) * chore: pre-commit autoupdate (#2740) updates: - [github.com/astral-sh/ruff-pre-commit: v0.7.1 → v0.7.2](astral-sh/ruff-pre-commit@v0.7.1...v0.7.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix: `datetime.datetime` instances in stream maps are now correctly mapped to `date-time` JSON schema strings (#2741) fix: `datetime.datetime` instances are correctly mapped to `date-time` JSON schema strings * feat(targets): SQL target developers can now more easily override the mapping from JSON schema to SQL column type (#2732) * feat(target): SQL target developers can now more easily override the mapping from JSON schema to SQL column type * Add failing test for complex type case * Correctly handle multiple types * Make mypy happy * Test more cases * Add docs * Fix annotation in docs * Support custom fallbacks * Add a way to customize raw string handling * feat(templates): Update dependencies in templates (#2742) * refactor: Deprecate passing file paths to plugin and stream initialization (#2743) * docs: Document the current release process (#2745) * chore: Update issue types in templates * ci: Run tests on `v*` branches (#2747) * chore(deps): bump the actions group with 2 updates (#2748) Bumps the actions group with 2 updates: [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) and [commitizen-tools/commitizen-action](https://github.com/commitizen-tools/commitizen-action). Updates `pypa/gh-action-pypi-publish` from 1.11.0 to 1.12.2 - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.11.0...v1.12.2) Updates `commitizen-tools/commitizen-action` from 0.21.0 to 0.22.0 - [Release notes](https://github.com/commitizen-tools/commitizen-action/releases) - [Changelog](https://github.com/commitizen-tools/commitizen-action/blob/master/CHANGELOG.md) - [Commits](commitizen-tools/commitizen-action@0.21.0...0.22.0) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: commitizen-tools/commitizen-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Release v0.42.0 (#2749) * chore: Bump package version * Update dev deps --------- Co-authored-by: edgarrmondragon <16805946+edgarrmondragon@users.noreply.github.com> Co-authored-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com> * refactor: Dropped support for Python 3.8 (#2751) * refactor: Dropped support for Python 3.8 * Update tests/core/test_connector_sql.py --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: MeltyBot <105875157+MeltyBot@users.noreply.github.com>

edgarrmondragon self-assigned this Nov 7, 2024

edgarrmondragon force-pushed the edgarrmondragon/refactor/deprecate-config-catalog-schema branch from 9bf3e79 to 7dbf9cb Compare November 7, 2024 00:04

edgarrmondragon mentioned this pull request Nov 7, 2024

refactor: Remove support for file paths in plugin and stream constructors #2744

Open

edgarrmondragon marked this pull request as ready for review November 7, 2024 00:15

edgarrmondragon requested a review from a team as a code owner November 7, 2024 00:15

edgarrmondragon added the kind/Tech Debt label Nov 7, 2024

edgarrmondragon added this to the v0.42.0 milestone Nov 7, 2024

refactor: Deprecate passing file paths to plugin and stream initializ…

208ccc7

…ation

edgarrmondragon force-pushed the edgarrmondragon/refactor/deprecate-config-catalog-schema branch from 7dbf9cb to 208ccc7 Compare November 7, 2024 00:16

edgarrmondragon added the Release Highlight Call this out in the release notes label Nov 7, 2024

edgarrmondragon merged commit ed3617c into main Nov 7, 2024
38 of 39 checks passed

edgarrmondragon deleted the edgarrmondragon/refactor/deprecate-config-catalog-schema branch November 7, 2024 00:20

edgarrmondragon mentioned this pull request Nov 7, 2024

feat: Add an extensible API for stream schema sources #2746

Open

edgarrmondragon added a commit that referenced this pull request Nov 11, 2024

refactor: Deprecate passing file paths to plugin and stream initializ…

e789630

…ation (#2743)

edgarrmondragon mentioned this pull request Nov 30, 2024

refactor: Fail early if input files to --catalog or --state do not exist #2788

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Deprecate passing file paths to plugin and stream initialization #2743

refactor: Deprecate passing file paths to plugin and stream initialization #2743

edgarrmondragon commented Nov 7, 2024 •

edited by github-actions bot

Loading

codspeed-hq bot commented Nov 7, 2024 •

edited

Loading

codecov bot commented Nov 7, 2024 •

edited

Loading

refactor: Deprecate passing file paths to plugin and stream initialization #2743

refactor: Deprecate passing file paths to plugin and stream initialization #2743

Conversation

edgarrmondragon commented Nov 7, 2024 • edited by github-actions bot Loading

codspeed-hq bot commented Nov 7, 2024 • edited Loading

CodSpeed Performance Report

Merging #2743 will not alter performance

Summary

codecov bot commented Nov 7, 2024 • edited Loading

Codecov Report

edgarrmondragon commented Nov 7, 2024 •

edited by github-actions bot

Loading

codspeed-hq bot commented Nov 7, 2024 •

edited

Loading

codecov bot commented Nov 7, 2024 •

edited

Loading