Skip to content

refactor: Remove support for file paths in plugin and stream constructors #2744

Open
@edgarrmondragon

Description

These add complexity for very little gain. Let's remove them in a future version.

elif isinstance(config, (str, PurePath)):
config_dict = read_json_file(config)

if isinstance(schema, (PathLike, str)):
if not Path(schema).is_file():
msg = f"Could not find schema file '{self.schema_filepath}'."
raise FileNotFoundError(msg)
self._schema_filepath = Path(schema)

sdk/singer_sdk/tap_base.py

Lines 103 to 104 in 62c03bb

elif catalog is not None:
self._input_catalog = Catalog.from_dict(read_json_file(catalog))

sdk/singer_sdk/tap_base.py

Lines 115 to 116 in 62c03bb

elif state:
state_dict = read_json_file(state)

Related:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions