Skip to content

Implement Doctrine discriminator maps for dynamic entity management #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

james2001
Copy link
Contributor

Pull Request

What does this PR do?

  • Implements Doctrine discriminator maps to enable dynamic entity management. This enhancement addresses the issue where indexing abstract or extended entities was not possible, by allowing efficient management of different entities within the same inheritance hierarchy. This simplifies data model extension and maintenance, making the system more flexible and robust.

PR checklist

Please check if your PR fulfills the following requirements:

  • Fixes the issue with indexing abstract or extended entities by utilizing Doctrine's discriminator maps, representing a significant architectural improvement.
  • I have read the contributing guidelines.
  • The title of the PR is accurate and descriptive of the changes made.

@norkunas
Copy link
Collaborator

norkunas commented Feb 1, 2024

Please add tests :)

@james2001 james2001 force-pushed the feature/doctrine-discriminator branch from 5ec678b to dcf10f2 Compare February 1, 2024 19:23
@james2001 james2001 force-pushed the feature/doctrine-discriminator branch from dcf10f2 to 3e00bfb Compare February 26, 2024 16:44
@norkunas
Copy link
Collaborator

norkunas commented Feb 27, 2024

@james2001 you should rebase your PR and update local deps as now your changes basically reverts #323

@james2001 james2001 force-pushed the feature/doctrine-discriminator branch from 3e00bfb to 3accd34 Compare February 27, 2024 17:16
@james2001
Copy link
Contributor Author

james2001 commented Feb 27, 2024

@norkunas I already rebase

image

It was the PHP version 😅

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.68%. Comparing base (41f6b95) to head (0d4e71b).
Report is 2 commits behind head on main.

Files Patch % Lines
src/Services/MeilisearchService.php 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #321      +/-   ##
============================================
- Coverage     86.73%   86.68%   -0.05%     
  Complexity        1        1              
============================================
  Files            19       19              
  Lines           814      811       -3     
============================================
- Hits            706      703       -3     
  Misses          108      108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@james2001 james2001 force-pushed the feature/doctrine-discriminator branch 3 times, most recently from 02817d1 to 7942f1f Compare February 27, 2024 19:54
@james2001 james2001 requested a review from norkunas February 29, 2024 15:27
@norkunas
Copy link
Collaborator

Tests should create then at least 1 article and 1 podcast :)

@james2001 james2001 force-pushed the feature/doctrine-discriminator branch from 029f413 to 0d4e71b Compare March 5, 2024 14:50
@norkunas
Copy link
Collaborator

norkunas commented Mar 5, 2024

bors merge

@james2001 james2001 closed this Mar 5, 2024
@meili-bors meili-bors bot merged commit 2d73e42 into meilisearch:main Mar 5, 2024
@norkunas
Copy link
Collaborator

norkunas commented Mar 5, 2024

Thank you @james2001 :)

@curquiza curquiza added the enhancement New feature or request label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants