-
Notifications
You must be signed in to change notification settings - Fork 33
Implement Doctrine discriminator maps for dynamic entity management #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Doctrine discriminator maps for dynamic entity management #321
Conversation
Please add tests :) |
5ec678b
to
dcf10f2
Compare
dcf10f2
to
3e00bfb
Compare
@james2001 you should rebase your PR and update local deps as now your changes basically reverts #323 |
3e00bfb
to
3accd34
Compare
@norkunas I already rebase It was the PHP version 😅 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
============================================
- Coverage 86.73% 86.68% -0.05%
Complexity 1 1
============================================
Files 19 19
Lines 814 811 -3
============================================
- Hits 706 703 -3
Misses 108 108 ☔ View full report in Codecov by Sentry. |
02817d1
to
7942f1f
Compare
Tests should create then at least 1 article and 1 podcast :) |
029f413
to
0d4e71b
Compare
bors merge |
Thank you @james2001 :) |
Pull Request
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements: