Skip to content

Fix CS #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix CS #323

merged 1 commit into from
Feb 14, 2024

Conversation

norkunas
Copy link
Collaborator

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas mentioned this pull request Feb 14, 2024
Merged
3 tasks
@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Feb 14, 2024
curquiza
curquiza previously approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

meili-bors bot added a commit that referenced this pull request Feb 14, 2024
@meili-bors @norkunas
Merge #323
fdec527 
323: Fix CS r=curquiza a=norkunas

# Pull Request

## Related issue
Fixes #<issue_number>

## What does this PR do?
- ...

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: Tomas <norkunas.tom@gmail.com>
@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Feb 14, 2024

Timed out.

@curquiza
Copy link
Member

bors merge

meili-bors bot added a commit that referenced this pull request Feb 14, 2024
@meili-bors @norkunas
Merge #323
0f58c0c 
323: Fix CS r=curquiza a=norkunas

# Pull Request

## Related issue
Fixes #<issue_number>

## What does this PR do?
- ...

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: Tomas <norkunas.tom@gmail.com>
@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Feb 14, 2024

Timed out.

@connorhu
Copy link
Contributor

As an outsider, this is a very interesting scene. :)

@norkunas
Copy link
Collaborator Author

norkunas commented Feb 14, 2024 •
edited
Loading

bors merge
but if you don’t, I will look for you, I will find you, and I will recode you

meili-bors bot added a commit that referenced this pull request Feb 14, 2024
@meili-bors @norkunas
Merge #323
8738ae9 
323: Fix CS r=norkunas a=norkunas

# Pull Request

## Related issue
Fixes #<issue_number>

## What does this PR do?
- ...

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: Tomas <norkunas.tom@gmail.com>
@curquiza
Copy link
Member

Not sure it's the fault of bors (for once!)
it's because it expects the following tests to run but cannot find them

  • integration-tests (PHP 8.3) (Symfony 6.3.*)
  • integration-tests (PHP 8.3) (Symfony 6.4.*)

See bors config -> Looks like gitHub does not run all the required tests: https://github.com/meilisearch/meilisearch-symfony/actions/runs/7902542352/job/21568437543

@connorhu
Copy link
Contributor

Five is an IT-mythical number. Somewhere there is a cap lurking.

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Feb 14, 2024

Canceled.

@norkunas
Copy link
Collaborator Author

Not sure it's the fault of bors (for once!) it's because it expects the following tests to run but cannot find them

  • integration-tests (PHP 8.3) (Symfony 6.3.*)
  • integration-tests (PHP 8.3) (Symfony 6.4.*)

yeah, they don't appear even after commit amend :/

@norkunas norkunas force-pushed the fix-cs branch 2 times, most recently from ffff477 to c3dd56a Compare February 14, 2024 15:00
@connorhu
Copy link
Contributor

Removing unsupported symfony (6.0, 6.1, 6.2, 6.3) versions would be a workround.
versions

@norkunas
Copy link
Collaborator Author

norkunas commented Feb 14, 2024 •
edited
Loading

but then we'd block people for nothing.. but if there are no other solutions, well then yes..
ok, removing just from ci :)

@norkunas norkunas force-pushed the fix-cs branch 3 times, most recently from 51a34e9 to fd4cea7 Compare February 14, 2024 15:35
@norkunas
Copy link
Collaborator Author

norkunas commented Feb 14, 2024 •
edited
Loading

still some jobs does not appear/are not started :/

@norkunas norkunas force-pushed the fix-cs branch 3 times, most recently from c6a2aaf to 77f901b Compare February 14, 2024 15:47
@norkunas
Copy link
Collaborator Author

@curquiza managed to fix it.
now these jobs:

integration-tests (PHP 8.0) (Symfony 6.0.*) Expected — Waiting for status to be reported
Required
integration-tests (PHP 8.1) (Symfony 6.1.*) Expected — Waiting for status to be reported
Required
integration-tests (PHP 8.2) (Symfony 6.2.*) Expected — Waiting for status to be reported
Required

should be removed from repo

@curquiza
Copy link
Member

@norkunas done ✅

bors merge

@curquiza
Copy link
Member

And now the famous error I get with Bors 🤦‍♀️

Uploading Capture d’écran 2024-02-14 à 16.51.33.png…

Merging by hand!

@curquiza curquiza merged commit 5bd8b3c into meilisearch:main Feb 14, 2024
@norkunas norkunas deleted the fix-cs branch February 14, 2024 15:58
@norkunas norkunas mentioned this pull request Feb 27, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

@brunoocasali brunoocasali Awaiting requested review from brunoocasali

Assignees
No one assigned
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norkunas @curquiza @connorhu