-
Notifications
You must be signed in to change notification settings - Fork 90
Support localized-attributes settings #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
meili-bors
merged 4 commits into
meilisearch:main
from
ellnix:language-settings-and-search-parameter-1011
Jan 16, 2025
Merged
Support localized-attributes settings #1060
meili-bors
merged 4 commits into
meilisearch:main
from
ellnix:language-settings-and-search-parameter-1011
Jan 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanders41
requested changes
Jan 15, 2025
tests/settings/test_settings_localized_attributes_meilisearch.py
Outdated
Show resolved
Hide resolved
tests/settings/test_settings_localized_attributes_meilisearch.py
Outdated
Show resolved
Hide resolved
You are correct here, it will work as is. |
- wrapping localized_attributes in a model - using Mapping instead of Dict
ellnix
commented
Jan 16, 2025
sanders41
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ellnix!
I replied to your questions, but TLDR it all looks good.
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Feb 18, 2025
1080: Update version for the next release (v0.34) r=Strift a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-python to a new version: "v0.34" 👇 CHANGELOG This version introduces features released on [Meilisearch v1.13.0](https://www.meilisearch.com/blog/meilisearch-1-13?utm_campaign=oss&utm_source=github&utm_medium=meilisearch-python) 🎉 ## ✨ New - [AI-powered search](https://www.meilisearch.com/docs/learn/ai_powered_search/getting_started_with_ai_search?utm_campaign=oss&utm_source=github&utm_medium=meilisearch-python) is now stable `@/Strift` ## 🚀 Enhancements * Support localized-attributes settings (#1060) `@/ellnix` * Support batches API (#1062) `@/ellnix` * Support searching for similar documents (#1063) `@/ellnix` ## ⚙️ Maintenance/misc * Add federated search code-sample (#1064) `@/ellnix` Thanks again to `@/ellnix,` and `@/Strift!` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Laurent Cazanove <lau.cazanove@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #1011
PR checklist
Please check if your PR fulfills the following requirements:
Not very experienced with python, let me know if I should have created a model for the localized attributes, similar to embedders or proximity precision.
Regarding #1011, I don't think anything needs to change in the search parameters, since those seem to be dynamic anyway.