Skip to content

Support localized-attributes settings #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ellnix
Copy link
Contributor

@ellnix ellnix commented Jan 15, 2025

Pull Request

Related issue

Fixes #1011

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Not very experienced with python, let me know if I should have created a model for the localized attributes, similar to embedders or proximity precision.

Regarding #1011, I don't think anything needs to change in the search parameters, since those seem to be dynamic anyway.

@curquiza curquiza added the enhancement New feature or request label Jan 15, 2025
@curquiza curquiza requested a review from sanders41 January 15, 2025 13:40
@sanders41
Copy link
Collaborator

Regarding #1011, I don't think anything needs to change in the search parameters, since those seem to be dynamic anyway.

You are correct here, it will work as is.

- wrapping localized_attributes in a model
- using Mapping instead of Dict
Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ellnix!

I replied to your questions, but TLDR it all looks good.

@sanders41
Copy link
Collaborator

bors merge

Copy link
Contributor

meili-bors bot commented Jan 16, 2025

@meili-bors meili-bors bot merged commit d0501ae into meilisearch:main Jan 16, 2025
11 checks passed
meili-bors bot added a commit that referenced this pull request Feb 18, 2025
1080: Update version for the next release (v0.34) r=Strift a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-python to a new version: "v0.34"

👇 CHANGELOG

This version introduces features released on [Meilisearch v1.13.0](https://www.meilisearch.com/blog/meilisearch-1-13?utm_campaign=oss&utm_source=github&utm_medium=meilisearch-python) 🎉

## ✨ New

- [AI-powered search](https://www.meilisearch.com/docs/learn/ai_powered_search/getting_started_with_ai_search?utm_campaign=oss&utm_source=github&utm_medium=meilisearch-python) is now stable `@/Strift`

## 🚀 Enhancements

* Support localized-attributes settings (#1060) `@/ellnix`
* Support batches API (#1062) `@/ellnix`
* Support searching for similar documents (#1063) `@/ellnix`

## ⚙️ Maintenance/misc

* Add federated search code-sample (#1064) `@/ellnix`

Thanks again to  `@/ellnix,` and `@/Strift!` 🎉


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Laurent Cazanove <lau.cazanove@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.10.0] Language settings & search parameter
3 participants