-
Notifications
You must be signed in to change notification settings - Fork 90
Support batches API #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support batches API #1062
Conversation
daf6e60
to
cbb59ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Batches are made of tasks, so it made sense to me for them to be handled by the TaskHandler, and be tested side by side with tasks.
As always, let me know if I did something stupid 😄
@sanders41 I put you as reviewer everywhere, but feel free to say you don't have the time of course 😁 |
cbb59ca
to
cdbebe4
Compare
Co-authored-by: sanders41 <sanders41@users.noreply.github.com>
cdbebe4
to
a7051c7
Compare
I applied your suggestions, and rebased to remove the conflict on code-samples. Should I try to update legacy code based on your suggestions, or should I leave it be? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
1080: Update version for the next release (v0.34) r=Strift a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-python to a new version: "v0.34" 👇 CHANGELOG This version introduces features released on [Meilisearch v1.13.0](https://www.meilisearch.com/blog/meilisearch-1-13?utm_campaign=oss&utm_source=github&utm_medium=meilisearch-python) 🎉 ## ✨ New - [AI-powered search](https://www.meilisearch.com/docs/learn/ai_powered_search/getting_started_with_ai_search?utm_campaign=oss&utm_source=github&utm_medium=meilisearch-python) is now stable `@/Strift` ## 🚀 Enhancements * Support localized-attributes settings (#1060) `@/ellnix` * Support batches API (#1062) `@/ellnix` * Support searching for similar documents (#1063) `@/ellnix` ## ⚙️ Maintenance/misc * Add federated search code-sample (#1064) `@/ellnix` Thanks again to `@/ellnix,` and `@/Strift!` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Laurent Cazanove <lau.cazanove@gmail.com>
Pull Request
Related issue
Fixes #1050