Fix OKHTTP dependency inconsistency
#863
Conversation
WalkthroughThe pull request removes the Gradle configuration that previously rejected pre-release dependency versions and updates the okhttp dependency from a version range to a fixed version 4.12.0. No changes were made to public APIs or exported entities. Changes
Possibly related PRs
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
larskristianhaga
changed the title
OKHTTP dependency inconsistency
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
build.gradle (1)
65-65: Centralize OkHttp version to avoid duplication
ThetestImplementationscope also hardcodesokhttp:4.12.0, mirroring theapideclaration. Consider introducing anext.okhttpVersion = '4.12.0'at the top of the file and referencing it in both places to reduce maintenance overhead and prevent drift.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
build.gradle(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: integration-and-unit-tests
🔇 Additional comments (1)
build.gradle (1)
56-56:❓ Verification inconclusive
Pin OkHttp dependency to stable release
Lockingokhttpto4.12.0prevents pulling in the unintended5.0.0-alphaartifacts, ensuring a consistent, stable client at both compile and runtime.Please verify no other configurations or transitive dependencies resolve a different OkHttp version:
🏁 Script executed:
#!/bin/bash # Ensure no alpha or RC versions of okhttp are pulled in ./gradlew dependencies --configuration runtimeClasspath | grep okhttpLength of output: 261
Pin OkHttp dependency to stable release
Lockingokhttpto4.12.0prevents pulling in unintended5.0.0-alphaartifacts, ensuring a consistent, stable client at both compile and runtime.The previous dependency check failed due to an invalid
JAVA_HOMEsetting. To confirm no other configurations or transitive dependencies pull in a different OkHttp version, please:• Ensure
JAVA_HOMEis set to a valid JDK installation.
• Re-run the dependencies check:./gradlew dependencies --configuration runtimeClasspath | grep okhttp
|
@brunoocasali tagging you since you worked on the last PR |
|
Build succeeded:
|
Pull Request
Following up on PR #856, that tried to fix the issue with dependency resolving to alpha version of the OKHTTP dependency.
Example repo that showcases that
meilisearch-java:0.14.6still resolves to OKHTTP5.0.0-alpha.16.https://github.com/larskristianhaga/Meilisearch-OKHTTP-dependency-crash-demo
What does this PR do?
4.12.0, which is the same used as test scope.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit