Skip to content

Enforce only v4.x versions are allowed for OkHTTP #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2025
Merged

Enforce only v4.x versions are allowed for OkHTTP #856

merged 3 commits into from
May 30, 2025

Conversation

brunoocasali
Copy link
Member

@brunoocasali brunoocasali commented May 30, 2025 •
edited by coderabbitai bot
Loading

Pull Request

Related issue

A user reported that their build was broken after a clean maven install due to the poor resource version constraints defined in the okhttp definition.

What does this PR do?

  • Ensure no other version than a stable one could be used.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

  • Chores
    • Updated the OkHttp library dependency to allow for automatic use of the latest version within major version 4.
    • Improved dependency management by excluding pre-release versions to ensure stability.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 30, 2025 •
edited
Loading

Walkthrough

A global configuration was added to reject pre-release dependency versions (alpha, beta, rc, milestone) by matching version strings with a regex during resolution.

Changes

File Change Summary
build.gradle Added global rejection of pre-release dependency versions via regex pattern in resolution strategy

Poem

A hop and a skip, no pre-release in sight,
Alpha, beta, RC take flight,
Stable versions now lead the way,
Our builds grow stronger day by day! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0dac6f9 and 34d979c.

📒 Files selected for processing (1)
  • build.gradle (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • build.gradle
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: integration-and-unit-tests
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 30, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09be090 and 72d9ee5.

📒 Files selected for processing (1)
  • build.gradle (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: integration-and-unit-tests

@brunoocasali brunoocasali added the enhancement New feature or request label May 30, 2025
@brunoocasali brunoocasali merged commit 8bb3199 into main May 30, 2025
3 checks passed
@brunoocasali brunoocasali deleted the fix-dep-range-syntax branch May 30, 2025 19:58
@larskristianhaga larskristianhaga mentioned this pull request Jun 2, 2025
Merged
3 tasks
meili-bors bot added a commit that referenced this pull request Jun 2, 2025
@meili-bors @larskristianhaga
Merge #863
5f56246 
863: Fix `OKHTTP` dependency inconsistency r=brunoocasali a=larskristianhaga

# Pull Request

Following up on PR #856, that tried to fix the issue with dependency resolving to alpha version of the OKHTTP dependency.

Example repo that showcases that `meilisearch-java:0.14.6` still resolves to OKHTTP `5.0.0-alpha.16`.
https://github.com/larskristianhaga/Meilisearch-OKHTTP-dependency-crash-demo

## What does this PR do?
- Pinning OKHTTP version to `4.12.0`, which is the same used as test scope. 
- Removed dependency selection rejection that did not work.

## PR checklist
Please check if your PR fulfills the following requirements:
- [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [X] Have you read the contributing guidelines?
- [X] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- **Chores**
  - Updated the okhttp dependency to a fixed version (4.12.0).
  - Removed restrictions that previously blocked pre-release dependency versions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Lars Kristian Haga <lars.kristian.haga@cappelendamm.no>
@brunoocasali brunoocasali mentioned this pull request Jun 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brunoocasali