This repository was archived by the owner on May 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Changes related to the next Meilisearch release (v1.0.0) #98
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9524d04
Update scripts/providers/aws/cloud-config.yaml
meili-bot 7e27583
Update scripts/providers/digitalocean/cloud-config.yaml
meili-bot 96e4a94
Update scripts/providers/gcp/cloud-config.yaml
meili-bot 5d5da0c
Changes due to rename dump command
alallema 1fda450
Merge branch 'main' into bump-meilisearch-v1.0.0
alallema File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ users: | |
- name: root | ||
shell: /bin/bash | ||
|
||
packages: | ||
packages: | ||
- git | ||
- curl | ||
- ufw | ||
|
@@ -28,8 +28,9 @@ write_files: | |
|
||
[Service] | ||
Type=simple | ||
ExecStart=/usr/bin/meilisearch --db-path /var/lib/meilisearch/data.ms --env development --dumps-dir MEILI_DUMPS_DIR | ||
Environment="MEILI_SERVER_PROVIDER=aws" | ||
Environment="MEILI_DUMP_DIR=/var/opt/meilisearch/dumps" | ||
ExecStart=/usr/bin/meilisearch --db-path /var/lib/meilisearch/data.ms --env development --dump-dir $MEILI_DUMP_DIR | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it correct to set as "development"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. By default, it's set as |
||
Restart=on-failure | ||
RestartSec=5s | ||
|
||
|
@@ -64,13 +65,13 @@ write_files: | |
meilisearch-setup | ||
|
||
runcmd: | ||
- wget --directory-prefix=/usr/bin/ -O /usr/bin/meilisearch https://github.com/meilisearch/meilisearch/releases/download/v0.30.5/meilisearch-linux-amd64 | ||
- wget --directory-prefix=/usr/bin/ -O /usr/bin/meilisearch https://github.com/meilisearch/meilisearch/releases/download/v1.0.0/meilisearch-linux-amd64 | ||
- chmod 755 /usr/bin/meilisearch | ||
- systemctl enable meilisearch.service | ||
- ufw --force enable | ||
- ufw allow 'Nginx Full' | ||
- ufw allow 'OpenSSH' | ||
- curl https://raw.githubusercontent.com/meilisearch/cloud-scripts/v0.30.5/scripts/deploy-meilisearch.sh | bash -s v0.30.5 aws | ||
- curl https://raw.githubusercontent.com/meilisearch/cloud-scripts/v1.0.0/scripts/deploy-meilisearch.sh | bash -s v1.0.0 aws | ||
|
||
power_state: | ||
mode: reboot | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ users: | |
- name: root | ||
shell: /bin/bash | ||
|
||
packages: | ||
packages: | ||
- git | ||
- curl | ||
- ufw | ||
|
@@ -28,8 +28,9 @@ write_files: | |
|
||
[Service] | ||
Type=simple | ||
ExecStart=/usr/bin/meilisearch --db-path /var/lib/meilisearch/data.ms --env development --dumps-dir MEILI_DUMPS_DIR | ||
Environment="MEILI_SERVER_PROVIDER=digitalocean" | ||
Environment="MEILI_DUMP_DIR=/var/opt/meilisearch/dumps" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||
ExecStart=/usr/bin/meilisearch --db-path /var/lib/meilisearch/data.ms --env development --dump-dir $MEILI_DUMP_DIR | ||
Restart=on-failure | ||
RestartSec=5s | ||
|
||
|
@@ -65,13 +66,13 @@ write_files: | |
|
||
runcmd: | ||
- apt-get purge droplet-agent* -y | ||
- wget --directory-prefix=/usr/bin/ -O /usr/bin/meilisearch https://github.com/meilisearch/meilisearch/releases/download/v0.30.5/meilisearch-linux-amd64 | ||
- wget --directory-prefix=/usr/bin/ -O /usr/bin/meilisearch https://github.com/meilisearch/meilisearch/releases/download/v1.0.0/meilisearch-linux-amd64 | ||
- chmod 755 /usr/bin/meilisearch | ||
- systemctl enable meilisearch.service | ||
- ufw --force enable | ||
- ufw allow 'Nginx Full' | ||
- ufw allow 'OpenSSH' | ||
- curl https://raw.githubusercontent.com/meilisearch/cloud-scripts/v0.30.5/scripts/deploy-meilisearch.sh | bash -s v0.30.5 digitalocean | ||
- curl https://raw.githubusercontent.com/meilisearch/cloud-scripts/v1.0.0/scripts/deploy-meilisearch.sh | bash -s v1.0.0 digitalocean | ||
- curl https://raw.githubusercontent.com/digitalocean/marketplace-partners/master/scripts/90-cleanup.sh | bash | ||
- curl https://raw.githubusercontent.com/digitalocean/marketplace-partners/master/scripts/99-img-check.sh | bash | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you sometimes set
Environment="MEILI_DUMP_DIR=/var/opt/meilisearch/dumps"
and other places haveEnvironment="MEILI_DUMP_DIR=$MEILI_DUMP_DIR"
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good question!
systemd
doesn't read the environment variable, so that is why there are defined directly on the file. It should probably be better to useEnvironmentFile=
instead ofEnvironment=
option and create an env file I didn't take time to do it but I maybe will before v1 if I can.