Changes related to the next Meilisearch release (v1.0.0) #98
Conversation
alallema
force-pushed
the
bump-meilisearch-v1.0.0
branch
from
2a410d5 to
5d5da0c
Compare
| Environment="MEILI_SERVER_PROVIDER=aws" | ||
| Environment="MEILI_DUMP_DIR=/var/opt/meilisearch/dumps" | ||
| ExecStart=/usr/bin/meilisearch --db-path /var/lib/meilisearch/data.ms --env development --dump-dir $MEILI_DUMP_DIR |
There was a problem hiding this comment.
Is it correct to set as "development"?
There was a problem hiding this comment.
By default, it's set as development because we don't set any masterKey.
At the first connexion you will have to choose if you want or no a masterKey and choose the environment
| Environment="MEILI_SERVER_PROVIDER=digitalocean" | ||
| Environment="MEILI_DUMP_DIR=/var/opt/meilisearch/dumps" |
| Environment="MEILI_SERVER_PROVIDER=aws" | ||
| Environment="MEILI_DUMP_DIR=/var/opt/meilisearch/dumps" |
There was a problem hiding this comment.
Why you sometimes set Environment="MEILI_DUMP_DIR=/var/opt/meilisearch/dumps" and other places have Environment="MEILI_DUMP_DIR=$MEILI_DUMP_DIR"
There was a problem hiding this comment.
This is a really good question! systemd doesn't read the environment variable, so that is why there are defined directly on the file. It should probably be better to use EnvironmentFile= instead of Environment= option and create an env file I didn't take time to do it but I maybe will before v1 if I can.
This PR gathers the changes related to the next Meilisearch release (v1.0.0) so that this package is ready when the official release is out.
This PR is auto-generated for the pre-release week purpose.
Related to this issue: meilisearch/integration-guides#230