feat: forge system #1391

gabrielew · 2025-10-19T22:11:41Z

Roadmap

Behavior

Actual

Do this and that doesn't happens

Expected

-- Result layout

2025-10-20.14-31-38.mp4

2025-10-20.14-29-54.mp4

Type of change

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I checked the PR checks reports
I have commented my code, particularly in hard-to-understand areas

…ances-in-ui Update forge status bar resource displays

…ith-forge-history-details Implement forge history pagination UI

…storypagelabel Fix forge history page label translation

…mestart-functionality Fix forge controller toggle lifecycle

…olor-to-red Ensure forge history pagination buttons revert color after release

…into feat/forge_system

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/client/protocolgamesend.cpp

gabrielew · 2025-10-27T13:32:10Z

@libergod @kokekanon can u review?

andreoam · 2025-11-10T12:50:46Z

I'm getting an error when compiling.

kokekanon · 2025-11-14T22:29:26Z

1) Sometimes I get this error in terminal on your PR.

[builtin#142]: at 0x7ff6091323f0
ERROR: lua function callback failed: LUA ERROR: attempt to call an expired lua function from C++,did you forget to hold a reference for that function?
stack traceback:
[builtin#142]: at 0x7ff6091323f0
ERROR: lua function callback failed: LUA ERROR: attempt to call an expired lua function from C++,did you forget to hold a reference for that function?
stack traceback:
[builtin#142]: at 0x7ff6091323f0

I think this fixes it. (untest)
0001-test.patch

2) to fix the compilation

add

int push_luavalue(const ForgeHistory& data);
int push_luavalue(const ForgeTierPrice& data);
int push_luavalue(const ForgeGradeData& data);
int push_luavalue(const ForgeClassTierPrices& data);
int push_luavalue(const ForgeResultData& data);
int push_luavalue(const ForgeConfigData& data);

can u review?

3) review

@gabrielew review

0001-Update-game_forge.css.patch

commit d22a2f9 Author: Luan Luciano <luanluciano@outlook.com> Date: Fri Nov 14 17:07:44 2025 -0300 fix: memory leak that occurs with each call to the decrypt() function Allocation of new uint8_t[size] without delete[] before the return commit 8cbb233 Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br> Date: Fri Nov 14 13:58:06 2025 -0300 ci/cl: set default vcpkg SHA and remove pin validation (mehah#1442) commit 0232575 Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br> Date: Thu Nov 13 16:23:03 2025 -0300 fix: add virtual destructor to ApplicationContext (mehah#1441) commit 8d7a83d Author: LIBERGOD <37589902+libergod@users.noreply.github.com> Date: Mon Nov 10 12:37:41 2025 -0800 imp: hide healthbar for npcs - global like commit d6ea8de Author: LIBERGOD <37589902+libergod@users.noreply.github.com> Date: Mon Nov 10 12:35:05 2025 -0800 fix: walk up/down in stacks commit 74c7d10 Author: divinity76 <hans@loltek.net> Date: Sun Nov 9 16:59:15 2025 +0100 fix: make README.md table of contents clickable (mehah#1431) commit a2e738b Author: SkullzOTS <86809689+SkullzOTS@users.noreply.github.com> Date: Sun Nov 9 00:08:07 2025 -0300 fix: android build commit a8703e0 Author: SkullzOTS <86809689+SkullzOTS@users.noreply.github.com> Date: Sat Nov 8 13:55:09 2025 -0300 improve: android features and fixes (mehah#1427) commit 96734c6 Author: Renato Machado <mehahx@gmail.com> Date: Fri Nov 7 21:42:10 2025 -0300 fix: onPositionChange not triggered mehah#1412 commit 502e1ba Author: Renato Machado <mehahx@gmail.com> Date: Fri Nov 7 15:02:57 2025 -0300 chore: update Discord support link for issues commit 9f6cc8f Author: LIBERGOD <37589902+libergod@users.noreply.github.com> Date: Fri Nov 7 09:41:04 2025 -0800 fix: game_actionbar problems to resize (mehah#1413) commit 6060992 Author: LIBERGOD <37589902+libergod@users.noreply.github.com> Date: Fri Nov 7 09:40:57 2025 -0800 fix: classic controls - right/left click not opening depot/chests (mehah#1414) commit 7eaa662 Author: divinity76 <hans@loltek.net> Date: Fri Nov 7 18:28:13 2025 +0100 feat: function OutputMessage:addBytes (mehah#1421) commit 4d7dd79 Author: divinity76 <hans@loltek.net> Date: Fri Nov 7 18:27:50 2025 +0100 fix: support 1fps support 1fps. the previous minimum is 10fps. hope it can save cpu. I am afk cavebotting on cpu-constrained VPS servers. commit d4b1114 Author: Renato Machado <mehahx@gmail.com> Date: Fri Nov 7 14:27:11 2025 -0300 chore: update Discord support link for issues (mehah#1423) commit f45462d Author: divinity76 <hans@loltek.net> Date: Thu Nov 6 12:50:33 2025 -0800 fix: typo scrupts > scripts (mehah#1420) commit efc8201 Author: Renato Machado <mehahx@gmail.com> Date: Sat Nov 1 21:00:32 2025 -0300 build: clean up includes in drawpool.h commit c109ff2 Author: Renato Machado <mehahx@gmail.com> Date: Sat Nov 1 20:29:33 2025 -0300 fix: ensure onPositionChange triggers properly while preWalking commit 3b12e70 Author: Renato Machado <mehahx@gmail.com> Date: Thu Oct 30 18:47:46 2025 -0300 build: fix compile without unity build (mehah#1410) commit efcb844 Author: SkullzOTS <86809689+SkullzOTS@users.noreply.github.com> Date: Tue Oct 28 15:25:46 2025 -0300 fix: build with discordRPC enabled (mehah#1409) commit acaf98d Author: Renato Machado <mehahx@gmail.com> Date: Tue Oct 28 00:23:01 2025 -0300 refactor: cleanup includes and extract structs/enums to separate headers (mehah#1397) - Removed unnecessary includes from header files. - Replaced heavy includes with forward declarations where applicable. commit 1645b2b Author: kokekanon <114332266+kokekanon@users.noreply.github.com> Date: Sat Oct 25 04:28:51 2025 -0300 improve: game_actionbar multiple Bars (mehah#1354) commit 9dd9540 Author: kokekanon <114332266+kokekanon@users.noreply.github.com> Date: Fri Oct 24 18:34:22 2025 -0300 improve: modalDialog , allow HTML string fix: mehah#929 (mehah#1396) commit dd3bc91 Author: Renato Machado <mehahx@gmail.com> Date: Fri Oct 24 18:33:58 2025 -0300 build: enable /DEBUG:FASTLINK to speed up link time in Debug builds (mehah#1402) commit d025cc8 Author: kokekanon <114332266+kokekanon@users.noreply.github.com> Date: Mon Oct 20 17:13:32 2025 -0300 fix(html): use placement position in older modules html/css (mehah#1393) commit f773c27 Author: Renato Machado <mehahx@gmail.com> Date: Mon Oct 20 01:40:33 2025 -0300 ci: harden all workflows and pin vcpkg actions by full commit SHA (mehah#1388) Co-authored-by: LIBERGOD <37589902+libergod@users.noreply.github.com> commit d90f700 Author: Renato Machado <mehahx@gmail.com> Date: Sun Oct 19 22:46:59 2025 -0300 improve: tag display definition commit e7ab6dd Author: Victor <vasconcellosdevictor@gmail.com> Date: Sun Oct 19 21:52:25 2025 -0300 fix: properly unbind hotkeys when clearing slots commit 2d83e9e Author: LIBERGOD <37589902+libergod@users.noreply.github.com> Date: Sun Oct 19 16:56:24 2025 -0700 fix: mapcontrols (mehah#1389) commit 6895e01 Author: LIBERGOD <37589902+libergod@users.noreply.github.com> Date: Sun Oct 19 16:55:55 2025 -0700 fix: outfits walking animation (mehah#1390) commit add480b Author: Renato Machado <mehahx@gmail.com> Date: Sun Oct 19 19:34:28 2025 -0300 feat(ui): add placement attribute for element alignment (mehah#1392)

This reverts commit fa4c215.

sonarqubecloud · 2025-11-19T20:07:55Z

Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

kokekanon and others added 30 commits September 28, 2025 18:07

feat: game_forge in Html / Css / TS

6825d09

Merge remote-tracking branch 'upstream/main' into forgehtml

ab7f4c6

Merge branch 'main' into feat/forge

a81d77f

wip: forge

19c7e37

Show forge resources from player balances

e70faf7

wip: browse forge history

cd5cc83

Merge pull request #37 from gabrielew/2025-10-03/display-resource-bal…

7de0138

…ances-in-ui Update forge status bar resource displays

chore: add log

82989e0

Implement forge history pagination

afb126f

Move forge history detail wrap styling to CSS

2d05733

Adjust forge history action column layout

083edc6

Adjust forge history action column sizing

0baaacc

Fix forge history layout and action labels

5d35871

Fix forge history row anchors

a99eaef

Fix forge history column widths

b82bbfd

Align forge history header layout

4fbabe7

fix: footer

15e4ded

Merge pull request #38 from gabrielew/2025-10-03/update-historymenu-w…

e62736e

…ith-forge-history-details Implement forge history pagination UI

Restore pagination button color after release

c6eedb9

Fix forge history page label translation

b7df88b

Expand forge history row height

3e5a772

fix: width

956dd4a

Merge pull request #41 from gabrielew/2025-10-03/fix-nil-return-in-hi…

4d77dac

…storypagelabel Fix forge history page label translation

wip: hide

74139c1

Fix forge window toggle lifecycle

ae0d7c1

Fix forge tab toggle appearance

730a2cb

chore: back code

16f271d

Merge pull request #42 from gabrielew/2025-10-03/fix-toggle-with-onga…

7f6b8fb

…mestart-functionality Fix forge controller toggle lifecycle

Merge pull request #39 from gabrielew/2025-10-03/change-page-button-c…

b299fd5

…olor-to-red Ensure forge history pagination buttons revert color after release

Merge branch 'feat/forge' into fix/forge-window-pos

4566dc7

gabrielew and others added 3 commits October 19, 2025 19:10

wip: forge

1868c66

init

c517735

Merge branch 'placement_support' of https://github.com/mehah/otclient …

0993be2

…into feat/forge_system

majestyotbr changed the title ~~Feat/forge system~~ feat: forge system Oct 19, 2025

gabrielew added 5 commits October 20, 2025 14:29

feat: forge result

2ffd395

chore: use controller

059f3ea

fix: some messages

61d61e7

fix: result.bonusLabel

03a1edb

fix: arrows

b8f5df4

gabrielew marked this pull request as ready for review October 21, 2025 10:37

chatgpt-codex-connector bot reviewed Oct 21, 2025

View reviewed changes

src/client/protocolgamesend.cpp Show resolved Hide resolved

src/client/protocolgamesend.cpp Show resolved Hide resolved

feat: descriptions

32d1259

libergod added 14 commits November 14, 2025 15:22

merge/rebranch

642d00d

Update staticdata.h

80ca12c

imp: koke suggestions

437a873

Merge branch 'main' into feat/forge_system

8cfa43d

Update thing.h

b217d06

Update game_forge.lua

09dbc23

Update game_forge.html

5afa6ef

fix bug with soundmanager?

fa4c215

Revert "fix bug with soundmanager?"

83385d2

This reverts commit fa4c215.

Imp - Fix errors, images

3f70f5d

Fix convergence and items borders

d442bf0

fix button

f083c49

Merge branch 'main' into pr/1391

c87af25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: forge system #1391

feat: forge system #1391

Uh oh!

gabrielew commented Oct 19, 2025 •

edited by libergod

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

gabrielew commented Oct 27, 2025

Uh oh!

andreoam commented Nov 10, 2025

Uh oh!

kokekanon commented Nov 14, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

feat: forge system #1391

Are you sure you want to change the base?

feat: forge system #1391

Uh oh!

Conversation

gabrielew commented Oct 19, 2025 • edited by libergod Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Roadmap

Behavior

Actual

Expected

Type of change

Checklist

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

gabrielew commented Oct 27, 2025

Uh oh!

andreoam commented Nov 10, 2025

Uh oh!

kokekanon commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1) Sometimes I get this error in terminal on your PR.

2) to fix the compilation

3) review

Uh oh!

sonarqubecloud bot commented Nov 19, 2025

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gabrielew commented Oct 19, 2025 •

edited by libergod

Loading

kokekanon commented Nov 14, 2025 •

edited

Loading