Skip to content

build: fix compile without unity build #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

build: fix compile without unity build #1410

merged 2 commits into from
Oct 30, 2025

Conversation

@mehah
Copy link
Owner

@mehah mehah commented Oct 29, 2025

No description provided.

@mehah mehah changed the title fix: miss includes fix: compile without unitybuild Oct 30, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 30, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ElMan1999
ElMan1999 approved these changes Oct 30, 2025
View reviewed changes
Copy link

@ElMan1999 ElMan1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved

@mehah mehah changed the title fix: compile without unitybuild fix: compile without unity build Oct 30, 2025
@mehah mehah changed the title fix: compile without unity build build: fix compile without unity build Oct 30, 2025
@mehah mehah merged commit 3b12e70 into main Oct 30, 2025
8 checks passed
@divinity76
Copy link
Contributor

divinity76 commented Nov 7, 2025

umm, switching from c++ references to C-pointers is usually not a good thing. what was the rationale here?

libergod added a commit to gabrielew/otclient that referenced this pull request Nov 14, 2025
@libergod
Squashed commit of the following:
dcc61e4 
commit d22a2f9
Author: Luan Luciano <luanluciano@outlook.com>
Date:   Fri Nov 14 17:07:44 2025 -0300

    fix: memory leak that occurs with each call to the decrypt() function

    Allocation of new uint8_t[size] without delete[] before the return

commit 8cbb233
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Fri Nov 14 13:58:06 2025 -0300

    ci/cl: set default vcpkg SHA and remove pin validation (mehah#1442)

commit 0232575
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Thu Nov 13 16:23:03 2025 -0300

    fix: add virtual destructor to ApplicationContext (mehah#1441)

commit 8d7a83d
Author: LIBERGOD <37589902+libergod@users.noreply.github.com>
Date:   Mon Nov 10 12:37:41 2025 -0800

    imp: hide healthbar for npcs - global like

commit d6ea8de
Author: LIBERGOD <37589902+libergod@users.noreply.github.com>
Date:   Mon Nov 10 12:35:05 2025 -0800

    fix: walk up/down in stacks

commit 74c7d10
Author: divinity76 <hans@loltek.net>
Date:   Sun Nov 9 16:59:15 2025 +0100

    fix: make README.md table of contents clickable (mehah#1431)

commit a2e738b
Author: SkullzOTS <86809689+SkullzOTS@users.noreply.github.com>
Date:   Sun Nov 9 00:08:07 2025 -0300

    fix: android build

commit a8703e0
Author: SkullzOTS <86809689+SkullzOTS@users.noreply.github.com>
Date:   Sat Nov 8 13:55:09 2025 -0300

    improve: android features and fixes (mehah#1427)

commit 96734c6
Author: Renato Machado <mehahx@gmail.com>
Date:   Fri Nov 7 21:42:10 2025 -0300

    fix: onPositionChange not triggered mehah#1412

commit 502e1ba
Author: Renato Machado <mehahx@gmail.com>
Date:   Fri Nov 7 15:02:57 2025 -0300

    chore: update Discord support link for issues

commit 9f6cc8f
Author: LIBERGOD <37589902+libergod@users.noreply.github.com>
Date:   Fri Nov 7 09:41:04 2025 -0800

    fix: game_actionbar problems to resize  (mehah#1413)

commit 6060992
Author: LIBERGOD <37589902+libergod@users.noreply.github.com>
Date:   Fri Nov 7 09:40:57 2025 -0800

    fix: classic controls - right/left click not opening depot/chests (mehah#1414)

commit 7eaa662
Author: divinity76 <hans@loltek.net>
Date:   Fri Nov 7 18:28:13 2025 +0100

    feat: function OutputMessage:addBytes (mehah#1421)

commit 4d7dd79
Author: divinity76 <hans@loltek.net>
Date:   Fri Nov 7 18:27:50 2025 +0100

    fix: support 1fps

    support 1fps. the previous minimum is 10fps. hope it can save cpu.

    I am afk cavebotting on cpu-constrained VPS servers.

commit d4b1114
Author: Renato Machado <mehahx@gmail.com>
Date:   Fri Nov 7 14:27:11 2025 -0300

    chore: update Discord support link for issues (mehah#1423)

commit f45462d
Author: divinity76 <hans@loltek.net>
Date:   Thu Nov 6 12:50:33 2025 -0800

    fix: typo scrupts > scripts (mehah#1420)

commit efc8201
Author: Renato Machado <mehahx@gmail.com>
Date:   Sat Nov 1 21:00:32 2025 -0300

    build: clean up includes in drawpool.h

commit c109ff2
Author: Renato Machado <mehahx@gmail.com>
Date:   Sat Nov 1 20:29:33 2025 -0300

    fix: ensure onPositionChange triggers properly while preWalking

commit 3b12e70
Author: Renato Machado <mehahx@gmail.com>
Date:   Thu Oct 30 18:47:46 2025 -0300

    build:  fix compile without unity build (mehah#1410)

commit efcb844
Author: SkullzOTS <86809689+SkullzOTS@users.noreply.github.com>
Date:   Tue Oct 28 15:25:46 2025 -0300

    fix: build with discordRPC enabled (mehah#1409)

commit acaf98d
Author: Renato Machado <mehahx@gmail.com>
Date:   Tue Oct 28 00:23:01 2025 -0300

    refactor: cleanup includes and extract structs/enums to separate headers (mehah#1397)

    - Removed unnecessary includes from header files.
    - Replaced heavy includes with forward declarations where applicable.

commit 1645b2b
Author: kokekanon <114332266+kokekanon@users.noreply.github.com>
Date:   Sat Oct 25 04:28:51 2025 -0300

    improve: game_actionbar multiple Bars (mehah#1354)

commit 9dd9540
Author: kokekanon <114332266+kokekanon@users.noreply.github.com>
Date:   Fri Oct 24 18:34:22 2025 -0300

    improve: modalDialog , allow HTML string fix: mehah#929 (mehah#1396)

commit dd3bc91
Author: Renato Machado <mehahx@gmail.com>
Date:   Fri Oct 24 18:33:58 2025 -0300

    build: enable /DEBUG:FASTLINK to speed up link time in Debug builds (mehah#1402)

commit d025cc8
Author: kokekanon <114332266+kokekanon@users.noreply.github.com>
Date:   Mon Oct 20 17:13:32 2025 -0300

    fix(html): use placement position in older modules html/css (mehah#1393)

commit f773c27
Author: Renato Machado <mehahx@gmail.com>
Date:   Mon Oct 20 01:40:33 2025 -0300

    ci: harden all workflows and pin vcpkg actions by full commit SHA (mehah#1388)

    Co-authored-by: LIBERGOD <37589902+libergod@users.noreply.github.com>

commit d90f700
Author: Renato Machado <mehahx@gmail.com>
Date:   Sun Oct 19 22:46:59 2025 -0300

    improve: tag display definition

commit e7ab6dd
Author: Victor <vasconcellosdevictor@gmail.com>
Date:   Sun Oct 19 21:52:25 2025 -0300

    fix: properly unbind hotkeys when clearing slots

commit 2d83e9e
Author: LIBERGOD <37589902+libergod@users.noreply.github.com>
Date:   Sun Oct 19 16:56:24 2025 -0700

    fix: mapcontrols (mehah#1389)

commit 6895e01
Author: LIBERGOD <37589902+libergod@users.noreply.github.com>
Date:   Sun Oct 19 16:55:55 2025 -0700

    fix: outfits walking animation (mehah#1390)

commit add480b
Author: Renato Machado <mehahx@gmail.com>
Date:   Sun Oct 19 19:34:28 2025 -0300

    feat(ui): add placement attribute for element alignment (mehah#1392)
@mehah mehah deleted the fix_include branch November 24, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ElMan1999 ElMan1999 ElMan1999 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehah @divinity76 @ElMan1999