Update for ffmpeg 6.0 #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some codecs (x264) it's necessary to set the codec while the context is being created, otherwise the codec-specific defaults aren't applied.
tilpner
force-pushed
the
v6
branch
4 times, most recently
from
aef2182 to
be52f1c
Compare
|
How aligned this is with the ffmpeg-next fork? |
…can directly cause memory unsafety
…rs, use coefficients_mut instead
…eeds_drop warning
… does nothing and is confusing
…ntext from stream metadata
…=Context> over AsRef
…rs from a codec context
through Encoder and Decoder
…ers from codec parameters
…ose if they don't
|
@kornelski Sorry for the frustrating delay. It is not aligned at all, as I didn't think to check ffmpeg-next (a combination of remembering that fork to be not-that-active either, and v6 being recent-ish). It probably would have saved me a lot of time. They do some backwards compatibility better than this PR does, and it appears they're sticking to the bitmask-only channel layout API (?). There's... some backwards compatibility in this PR, but it's not really tested. This is not a decision to never again support older ffmpeg versions, but I don't want to block v6 support on getting proper cross-version testing set up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this breaks compatibility with older ffmpeg versions in multiple ways.
Assumes meh/rust-ffmpeg-sys#104 is used as
ffmpeg-sys.