Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(#80): pin docker images versions to the versions currently used #84

Merged
merged 5 commits into from
Aug 30, 2023
Merged

chore(#80): pin docker images versions to the versions currently used #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9fbade3
chore(#80): pin docker images versions to current versions used
m5r Aug 15, 2023
b0663e6
chore(#80): remove commented latest versions to check if dependabot c…
m5r Aug 15, 2023
469d6d7
chore(#80): pin postgres exporter to currently used version
m5r Aug 15, 2023
263e5f1
chore(#80): pin development images versions
m5r Aug 15, 2023
d8884e1
fix(#80): fix postgres-exporter version tag
m5r Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion development/docker-compose.smtp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: "3.9"

services:
maildev:
image: maildev/maildev:latest
image: maildev/maildev:2.1.0
ports:
- "1080:1080"
networks:
Expand Down
4 changes: 2 additions & 2 deletions development/fake-cht/docker-compose.fake-cht.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ volumes:

services:
fake-cht:
image: node:latest
image: node:lts-alpine
user: "node"
working_dir: /home/node/app
volumes:
Expand All @@ -17,7 +17,7 @@ services:
npm start"

postgres:
image: postgres:latest
image: postgres:15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about leaving this as latest? At this point we are setting a definite minimum limit for which version of postgres we support, but we are not yet tracking any max version. From a testing perspective it might be nice to have a heads-up that a new version of postgres is incompatible. ....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did think about leaving the latest tag for local development images and I don't have a strong opinion for either solution

I'm merging the PRs as they are and we can keep the discussion going

environment:
POSTGRES_DB: cht
POSTGRES_USER: postgres_root
Expand Down
6 changes: 3 additions & 3 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ volumes:

services:
prometheus:
image: prom/prometheus:${PROMETHEUS_VERSION:-latest}
image: prom/prometheus:${PROMETHEUS_VERSION:-v2.44.0}
command:
- '--config.file=/etc/prometheus/prometheus.yml'
- '--storage.tsdb.path=/prometheus'
Expand All @@ -34,7 +34,7 @@ services:
restart: always

grafana:
image: grafana/grafana-oss:${GRAFANA_VERSION:-latest}
image: grafana/grafana-oss:${GRAFANA_VERSION:-9.5.3}
jkuester marked this conversation as resolved.
Show resolved Hide resolved
ports:
- "${GRAFANA_BIND:-127.0.0.1}:${GRAFANA_PORT:-3000}:3000"
volumes:
Expand All @@ -51,7 +51,7 @@ services:
restart: always

json-exporter:
image: prometheuscommunity/json-exporter:${JSON_EXPORTER_VERSION:-latest}
image: prometheuscommunity/json-exporter:${JSON_EXPORTER_VERSION:-v0.6.0}
volumes:
- ./exporters/json/config/cht.yml:/config.yml:ro
networks:
Expand Down
2 changes: 1 addition & 1 deletion exporters/postgres/docker-compose.postgres-exporter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ services:
- ./exporters/postgres/postgres-instances.yml:/etc/prometheus/postgres-instances.yml:ro
- ./exporters/postgres/config/scrape_config.yml:/etc/prometheus/scrape_configs/cht-postgres.yml:ro
postgres-exporter:
image: prometheuscommunity/postgres-exporter:${POSTGRES_EXPORTER_VERSION:-latest}
image: prometheuscommunity/postgres-exporter:${POSTGRES_EXPORTER_VERSION:-v0.13.0}
command:
- '--config.file=/etc/postgres-exporter/postgres_exporter.yml'
# disables the collection of all metrics except for custom queries (https://github.com/medic/cht-watchdog/issues/70)
Expand Down