chore(#80): pin docker images versions to the versions currently used #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkuester
approved these changes
Aug 29, 2023
| @@ -17,7 +17,7 @@ services: | |||
| npm start" | |||
|
|
|||
| postgres: | |||
| image: postgres:latest | |||
| image: postgres:15 | |||
There was a problem hiding this comment.
What do you think about leaving this as latest? At this point we are setting a definite minimum limit for which version of postgres we support, but we are not yet tracking any max version. From a testing perspective it might be nice to have a heads-up that a new version of postgres is incompatible. ....
There was a problem hiding this comment.
I did think about leaving the latest tag for local development images and I don't have a strong opinion for either solution
I'm merging the PRs as they are and we can keep the discussion going
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No dependabot automation included, as discussed in the issue