Skip to content

Pause #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pause #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
670a872
added pause feature
ricorandom May 24, 2023
a7007a9
added ownable
ricorandom May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions contracts/ERC721MOperatorFilterer.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@

pragma solidity ^0.8.4;

import "@openzeppelin/contracts/access/Ownable.sol";

import "./ERC721M.sol";
import "./OperatorFilter/DefaultOperatorFilterer.sol";

contract ERC721MOperatorFilterer is ERC721M, DefaultOperatorFilterer {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than modifying ERC721MOperatorFilterer, recommend creating a new variant like ERC721MOperatorFiltererPausable which extends ERC721MOperatorFilterer

Also thoughts on using Pausable?

bool public _tradable = false;

constructor(
string memory collectionName,
string memory collectionSymbol,
Expand Down Expand Up @@ -50,4 +54,22 @@ contract ERC721MOperatorFilterer is ERC721M, DefaultOperatorFilterer {
) public payable override(ERC721A, IERC721A) onlyAllowedOperator(from) {
super.safeTransferFrom(from, to, tokenId, data);
}

function setTradable(bool tradable) external onlyOwner
{
_tradable = tradable;
}

function _beforeTokenTransfer(
address from,
address to,
uint256 tokenId
) internal virtual override(ERC721) {
if (
_tradable != true
) {
revert("Transfers are currently disabled");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to revert an error: https://github.com/magicoss/erc721m/blob/main/contracts/IERC721M.sol#L7-L27

}
super._beforeTokenTransfer(from, to, tokenId);
}
}