Pause #87
Open
Pause #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mi-yu
reviewed
May 24, 2023
| if ( | ||
| _tradable != true | ||
| ) { | ||
| revert("Transfers are currently disabled"); |
There was a problem hiding this comment.
prefer to revert an error: https://github.com/magicoss/erc721m/blob/main/contracts/IERC721M.sol#L7-L27
mi-yu
reviewed
May 24, 2023
| import "./ERC721M.sol"; | ||
| import "./OperatorFilter/DefaultOperatorFilterer.sol"; | ||
|
|
||
| contract ERC721MOperatorFilterer is ERC721M, DefaultOperatorFilterer { |
There was a problem hiding this comment.
rather than modifying ERC721MOperatorFilterer, recommend creating a new variant like ERC721MOperatorFiltererPausable which extends ERC721MOperatorFilterer
Also thoughts on using Pausable?
|
Hi Mi Yu,
Pausable <https://docs.openzeppelin.com/contracts/4.x/api/security#Pausable>
works, i'd be happy to use that instead, do you want me to make that
amendment?
…On Wed, May 24, 2023 at 8:06 PM Michael Yu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In contracts/ERC721MOperatorFilterer.sol
<#87 (comment)>:
> @@ -2,10 +2,14 @@
pragma solidity ^0.8.4;
+import ***@***.***/contracts/access/Ownable.sol";
+
import "./ERC721M.sol";
import "./OperatorFilter/DefaultOperatorFilterer.sol";
contract ERC721MOperatorFilterer is ERC721M, DefaultOperatorFilterer {
rather than modifying ERC721MOperatorFilterer, recommend creating a new
variant like ERC721MOperatorFiltererPausable which extends
ERC721MOperatorFilterer
Also thoughts on using Pausable
<https://docs.openzeppelin.com/contracts/4.x/api/security#Pausable>?
—
Reply to this email directly, view it on GitHub
<#87 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5E5MOEJSYVPAXFWXJ7QYY3XHZL4NANCNFSM6AAAAAAYNRLECM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the pause feature and the import for the ownable contract.