Skip to content

Conversation

@JounQin
Copy link
Member

@JounQin JounQin commented Mar 25, 2021

lf is ensured by .editorconfig already and it results file difference on build

https://github.com/mdx-js/mdx/runs/2193584817#step:6:15

I don't know if there is a better way to fix this issue. And don't know why types files are effected by building, could be a bug of microbundle?

lf is ensured by .editorconfig already and it result file difference on build

https://github.com/mdx-js/mdx/runs/2193584817\#step:6:15
@vercel
Copy link

vercel bot commented Mar 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/4cUrqcNj9GBSR6gTkZKXcwbVtaxF
✅ Preview: https://mdx-git-ci-publish-mdx.vercel.app

@JounQin JounQin requested a review from ChristianMurphy March 25, 2021 14:24
@wooorm
Copy link
Member

wooorm commented Mar 25, 2021

lf is ensured by .editorconfig already and it results file difference on build

.editorconfig is about editors. .gitconfig is about Git. They’re different things.

And don't know why types files are effected by building, could be a bug of microbundle?

.d.ts files are generated by typescript (not microbundle).

Might adding .d.ts to .gitignore be a better solution?

@JounQin
Copy link
Member Author

JounQin commented Mar 25, 2021

.d.ts files are generated by typescript (not microbundle).

I checked the build script, only microbundle is called.

I agree we need to find a better solution.

@ChristianMurphy Any idea, the types are all rewritten at 0c3c79d

Maybe @johno meet this issue too.

@JounQin JounQin closed this Mar 25, 2021
@JounQin JounQin deleted the ci/publish branch March 25, 2021 14:53
@JounQin
Copy link
Member Author

JounQin commented Mar 25, 2021

It is also weird that I cannot reproduce the CI error anymore after removing .gitattributes and reverting it back...

@ChristianMurphy
Copy link
Member

I cannot reproduce the CI error anymore

When checking this locally I saw the same thing.
I was able to reproduce the error once running yarn test at the root level.
But haven't been able to replicate it again, or narrow down which command caused the d.ts files to change. 🤔 🕵️

@JounQin
Copy link
Member Author

JounQin commented Apr 6, 2021

After digging deep, I found out that it was caused by microbundle

See also developit/microbundle#829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants