Skip to content

Conversation

@JounQin
Copy link
Contributor

@JounQin JounQin commented Apr 6, 2021

close #829

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2021

🦋 Changeset detected

Latest commit: 591e1cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
microbundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rschristian
Copy link
Collaborator

What's the use case for this?

As types and typings are the only standardized keys for TS types, I can't see why you'd want to generate types without having those keys present? Right now I'd say it would make more sense to go the other way, and remove generateTypes, though perhaps I'm not seeing a certain use case?

@JounQin
Copy link
Contributor Author

JounQin commented Apr 8, 2021

@rschristian We want to write the typesfile manually.

See mdx-js/mdx#1496 (comment)

mdx-js/mdx@0c3c79d

@rschristian
Copy link
Collaborator

Ah, yeah, that makes sense.

@JounQin
Copy link
Contributor Author

JounQin commented Apr 22, 2021

friendly ping @developit

@developit developit merged commit 54402ac into developit:master May 5, 2021
@developit
Copy link
Owner

Ran into this exact issue yesterday, and your PR seems to be the right fix! Thanks.

@preact-bot preact-bot mentioned this pull request May 5, 2021
@JounQin JounQin deleted the fix/generateTypes branch May 5, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generateTypes is not available in cli, and generateTypes: false is not woking

3 participants