Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortran standard and Tapenade update #16

Merged
merged 15 commits into from
Oct 12, 2022
Merged

Fortran standard and Tapenade update #16

merged 15 commits into from
Oct 12, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Sep 13, 2022

Purpose

Following what was done in mdolab/adflow#228, I updated complexify.f90 so that pySurf complies with the F2008 standard. I also updated the Tapenade version to 3.16, which is what all our codes other than ADflow now use.

Lastly, I added the fprettify commit hash from #15 to .git-blame-ignore-revs so that changes from that PR do not show up when you git blame.

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner September 13, 2022 18:53
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #16 (df2463d) into main (56789f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   49.97%   49.97%           
=======================================
  Files           5        5           
  Lines        1683     1683           
=======================================
  Hits          841      841           
  Misses        842      842           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yqliaohk
yqliaohk previously approved these changes Sep 27, 2022
Copy link
Contributor

@eirikurj eirikurj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, see comments. Note, I just briefly skimmed the AD code, but it should be fine.

src/adjoint/Makefile Outdated Show resolved Hide resolved
config/defaults/config_LINUX_INTEL.mk Outdated Show resolved Hide resolved
src/adjoint/Intersection_b.f90 Outdated Show resolved Hide resolved
@sseraj sseraj requested a review from yqliaohk October 12, 2022 15:51
@yqliaohk yqliaohk merged commit 30df0ef into main Oct 12, 2022
@sseraj sseraj deleted the standard branch October 12, 2022 18:26
@sseraj sseraj mentioned this pull request Nov 2, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants