-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fortran standard and Tapenade update #16
Conversation
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 49.97% 49.97%
=======================================
Files 5 5
Lines 1683 1683
=======================================
Hits 841 841
Misses 842 842 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, see comments. Note, I just briefly skimmed the AD code, but it should be fine.
Purpose
Following what was done in mdolab/adflow#228, I updated complexify.f90 so that pySurf complies with the F2008 standard. I also updated the Tapenade version to 3.16, which is what all our codes other than ADflow now use.
Lastly, I added the fprettify commit hash from #15 to .git-blame-ignore-revs so that changes from that PR do not show up when you git blame.
Expected time until merged
1 week
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable