Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fprettify #15

Merged
merged 2 commits into from
Sep 12, 2022
Merged

fprettify #15

merged 2 commits into from
Sep 12, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Aug 25, 2022

Purpose

Formatting the Fortran code with fprettify

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Current tests pass

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner August 25, 2022 15:27
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #15 (3bb5df6) into main (8312cc9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   49.97%   49.97%           
=======================================
  Files           5        5           
  Lines        1683     1683           
=======================================
  Hits          841      841           
  Misses        842      842           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@eirikurj eirikurj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@anilyil anilyil merged commit 579c967 into main Sep 12, 2022
@anilyil anilyil deleted the fprettify branch September 12, 2022 14:58
@sseraj sseraj mentioned this pull request Sep 13, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants