Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies in setup.py #269

Merged
merged 5 commits into from
Mar 2, 2023
Merged

Updated dependencies in setup.py #269

merged 5 commits into from
Mar 2, 2023

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Mar 2, 2023

Purpose

Closes #205

I ignored the dependencies in the dynamic stability files because they are unused and do not work. I opened a separate issue (#268) to remove or refactor those files.

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner March 2, 2023 15:50
@sseraj sseraj requested review from lamkina and eirikurj March 2, 2023 15:50
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #269 (b79a1c6) into main (770e098) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   40.77%   40.77%           
=======================================
  Files          13       13           
  Lines        3882     3882           
=======================================
  Hits         1583     1583           
  Misses       2299     2299           
Impacted Files Coverage Δ
adflow/pyADflow.py 66.62% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't check the doc build from the tests (issue that we might figure out separately) but everything else looks fine. Thanks for cleaning this up!

@sseraj
Copy link
Collaborator Author

sseraj commented Mar 2, 2023

I can't check the doc build from the tests

It's strange that clicking 'Details' isn't going straight to the docs page. You should be able to click 'View docs' from the build page to get there though.

@sseraj sseraj merged commit 3865037 into main Mar 2, 2023
@sseraj sseraj deleted the update-setup branch March 2, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documenting additional python imports
3 participants