Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flaws): ignore casing of text fragments #9882

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Oct 25, 2023

Summary

Fixes #8313.

Problem

Text fragments were reported as "broken links" if they contained a non-lowercase letter.

Solution

Exclude hashes from the check that start with the fragment directive (:~:).


Screenshots

Before

image

After

image

How did you test this change?

  1. Locally reverted the changes of Run "yarn tool fix-flaws" on /web content#28009 to files/en-us/web/text_fragments/index.md, because it changed those fragment directives to lowercase.
  2. Ran yarn && yarn dev with REACT_APP_WRITER_MODE=true and opened http://localhost:5042/en-US/docs/Web/Text_fragments#_flaws locally.

@github-actions github-actions bot added the flaw-system issues and feature requests related to the flaws system label Oct 25, 2023
@caugner caugner requested a review from a team October 25, 2023 17:47
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caugner caugner merged commit fc51e08 into main Oct 26, 2023
12 checks passed
@caugner caugner deleted the dont-report-text-fragments-as-broken-link branch October 26, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaw-system issues and feature requests related to the flaws system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not raise "Anchor not lowercase" flaw when the anchor is a fragment directive
2 participants