Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not raise "Anchor not lowercase" flaw when the anchor is a fragment directive #8313

Closed
3 tasks done
teoli2003 opened this issue Feb 26, 2023 · 0 comments · Fixed by #9882
Closed
3 tasks done

Do not raise "Anchor not lowercase" flaw when the anchor is a fragment directive #8313

teoli2003 opened this issue Feb 26, 2023 · 0 comments · Fixed by #9882
Assignees
Labels
enhancement Improves an existing feature. flaw-system issues and feature requests related to the flaws system has PR Issues that already have a PR macros tracking issues related to kumascript macros p3 We don't have visibility when this will be addressed. wx writer experience

Comments

@teoli2003
Copy link
Contributor

teoli2003 commented Feb 26, 2023

Summary

Yari raises an Anchor not lowercase flaw when internal URL anchors have uppercase letters. This is good, and it allows us to detect and fix them (we have fixed almost all of them).

Text fragments is an extension to the anchor system that allows linking to a portion of text in a web document. Unlike traditional anchors, they are not set by the web page author.

We have two links to demonstrate this new feature on this page. They are flagged as flaws and shouldn't be.

URL

https://developer.mozilla.org/en-US/docs/Web/Text_fragments

Reproduction steps

  1. Go to the page (in a locally-run instance of mdn/content displaying flaws at the top)
  2. Look at the flaws: here they are

Expected behavior

No Anchor not lowercase flaw for anchors starting with the fragment directive (:~:).

Actual behavior

An Anchor not lowercase flaw listed for each anchor starting with the fragment directive (:~:).

Device

Desktop

Browser

Chrome

Browser version

Stable

Operating system

Android

Screenshot

Capture d’écran 2023-02-26 à 08 54 28

Anything else?

To fix this, we should always prevent fragments starting with :~: from raising a flaw.

Validations

@teoli2003 teoli2003 changed the title Do not raise "Anchor not lowercase" if the anchor is a fragment directive Do not raise "Anchor not lowercase" flaw when the anchor is a fragment directive Feb 26, 2023
@caugner caugner self-assigned this Feb 27, 2023
@bsmth bsmth added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. and removed needs-triage labels Mar 3, 2023
@caugner caugner added enhancement Improves an existing feature. p3 We don't have visibility when this will be addressed. flaw-system issues and feature requests related to the flaws system macros tracking issues related to kumascript macros wx writer experience and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Sep 28, 2023
@caugner caugner added accepting PR We invite you to open a PR to resolve this issue. and removed accepting PR We invite you to open a PR to resolve this issue. labels Oct 25, 2023
@caugner caugner added the has PR Issues that already have a PR label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing feature. flaw-system issues and feature requests related to the flaws system has PR Issues that already have a PR macros tracking issues related to kumascript macros p3 We don't have visibility when this will be addressed. wx writer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants