Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ...args, not arguments #2747

Merged
merged 1 commit into from
Jan 29, 2021
Merged

use ...args, not arguments #2747

merged 1 commit into from
Jan 29, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Jan 29, 2021

welcome to ES 2021 :)

@peterbe peterbe requested a review from nschonni January 29, 2021 17:07
@peterbe peterbe mentioned this pull request Jan 29, 2021
Merged
nschonni
nschonni approved these changes Jan 29, 2021
View reviewed changes
Copy link
Collaborator

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM, but since you mention ES 2021, does the ESLint parser version also need to get bumped?

@peterbe
Copy link
Contributor Author

peterbe commented Jan 29, 2021

RSLGTM, but since you mention ES 2021, does the ESLint parser version also need to get bumped?

I was just being silly. Pun intended.
I think I copied that lazy function from some old project of mine that dates back to when we didn't have argument destructuring.

@peterbe peterbe merged commit 8a60bcf into mdn:master Jan 29, 2021
@peterbe
Copy link
Contributor Author

peterbe commented Jan 29, 2021

does the ESLint parser version also need to get bumped?

Perhaps some day. I'm not sure. That's a big bucket of worms.

@peterbe peterbe deleted the use-args-not-arguments branch January 29, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterbe @nschonni