chore: Opt in more folders to ESLint

[nschonni]

No description provided.

[nschonni]

I left out opting in the libs/ since there are some funnier changes like another sub-yarn.lock needed

[nschonni]

This can be removed if #2156 lands, as it just complains if it isn't a registered bin value

[nschonni]

This was for the arguments call, and could probably be inline instead

[peterbe]

What arguments call??

[nschonni]

yari/ssr/render.js

Line 53 in a366301

res = creator.apply(this, arguments);

[peterbe]

Remove this line and wait for #2747
I tested it and it means we don't need to have this rule.

[nschonni]

I think the plugin just doesn't understand the local dependencies like "@yari-internal/constants": "file:../../../libs/constants", in the package.json, so ignored at the file level here. A few others under the libs/ so maybe a better solution is needed globally later

[nschonni]

@peterbe I'm guessing this is for your review

[peterbe]

Looks very promising. I just don't get the inclusion of the tsx files. create-react-app isn't perfect(*), far from it, but it's quite well maintained and it does take care of setting up its own eslint configuration.

(*) One frustrating thing is that you have to run yarn build to find out what eslint violations you have. Or you can start the webpack dev server (yarn start) and it'll print them out on the terminal. I wish it would ship with something similar to yarn build but basically work like we do with our Node code (much thanks to you!)

[peterbe]

So let's wait for #2747 and wait for @fiji-flo to explain why we have that second unused argument in the Lambda handler function.