This repository was archived by the owner on Oct 17, 2025. It is now read-only.
Update example to be unambiguous #1892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
teoli2003
approved these changes
Aug 17, 2021
teoli2003
suggested changes
Aug 17, 2021
NP, I was waiting that the OP would do the changes. |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Apologies <3 I meant to do this and the responses to my original issue were lost in the many emails from GitHub I get. Thanks for picking up my slack <3 |
No Problem. |
|
This was merged 3 weeks ago but doesn't seem to be live yet. See also mdn issue 2372 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.