Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Conversation

@Biki-das
Copy link
Contributor

the eariler code,at line no.3 had a return of 'process as infinity' with a negative value attached to it, this is a false operation for MIN_VALUE, which represents the adjacent positive value to 0, and not the most negative number

the eariler code,at line no.3 had a return of 'process as infinity' with a negative value attached to it, this is a false operation for MIN_VALUE, which represents the adjacent positive value to 0, and not the most negative number
@welcome
Copy link

welcome bot commented Aug 16, 2021

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

@Biki-das Biki-das mentioned this pull request Aug 16, 2021
@AnilSeervi
Copy link
Contributor

Original Issue mdn/content#7975
Perhaps you may coordinate with original creator of the issue and get his opinion.

@peterbe peterbe requested a review from teoli2003 August 16, 2021 18:39
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@teoli2003 teoli2003 merged commit 2ac15ad into mdn:master Aug 16, 2021
@welcome
Copy link

welcome bot commented Aug 16, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@AnilSeervi
Copy link
Contributor

Both the inputs to the changes you've made result in false and output the multiplied value.
I did suggest you to coordinate with the OP to get his insight.
Nevertheless I've opened #1892 with the suggestions of the OP.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants