-
Notifications
You must be signed in to change notification settings - Fork 22.8k
Make overview pages of modules consistent #15315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @glmvc, thanks for the PR. I'm afraid the "web" to "Web" change is not correct. Check this: https://developer.mozilla.org/en-US/docs/MDN/Guidelines/Writing_style_guide#capitalization. I'll review the other changes shortly. |
I think it is better to leave the section headings as "Conclusion" in Getting started with the Web. If you notice, the "Conclusion" section only exists on the "HTML basics", "CSS basics", and "Javascript basics" pages and the content of these sections is very different from the "Summary" sections in the other modules of the learning area. In fact, changing those "Conclusion" headings to "Summary" might almost be incorrect because we're not technically summarizing the concepts covered on the page, just concluding with the resultant web page after following the instructions. |
@dipikabh Thank you for reviewing this pr and helping out!
Also thanks for referring to the writing style guides - I somehow did not get the idea to check there before making changes - I am very sorry! I have of course undone the affected changes. But I have changed the spelling of the article titles to sentence case - I hope this fits better now :)
I agree with you about the "Conclusion" sections, it was a too quick change on my part, without really thinking about it more carefully - also sorry. (I have of course undone that too) |
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
Summary
made overview pages of modules in the learning area and the references more consistent:
Motivation
-> to keep things consistent
I have done this "consistency changes" now a few times in prs and it was always appreciated
Metadata