-
Notifications
You must be signed in to change notification settings - Fork 22.8k
Update index.md where an assessment page is restructured correctly (v2) #13781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
files/en-us/learn/css/first_steps/styling_a_biography_page/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, @glmvc ! It looks good.
You will see that every article in this module should have an "In this module" section (e.g. https://developer.mozilla.org/en-US/docs/Learn/CSS/First_steps/How_CSS_is_structured#in_this_module) and because you've renamed one of the articles, you'll need to update all of these.
You'll also need to update the PreviousMenuNext
macro calls in the page before this one (e.g.
{{PreviousMenuNext("Learn/CSS/First_steps/How_CSS_is_structured", "Learn/CSS/First_steps/Using_your_new_knowledge", "Learn/CSS/First_steps")}} |
{{PreviousMenuNext("Learn/CSS/First_steps/How_CSS_is_structured", "Learn/CSS/First_steps/Using_your_new_knowledge", "Learn/CSS/First_steps")}} |
I've had the question several times and still don't know where the "Assessment:" prefix in the navigation/sidebar left of the page comes from? Is this added automatically or must something be done here?
The Learn sidebar is built using a macro: LearnSidebar.ejs
. That macro really consists of two things:
- a big dictionary called
text
(https://github.com/mdn/yari/blob/201f6155c973c6864367d0f123f6176f4ccbf38a/kumascript/macros/LearnSidebar.ejs#L14) which maps string identifiers like "Using_your_new_knowledge" onto strings in various languages - an HTML template thing that describes what should appear in the sidebar. You need to update this bit: https://github.com/mdn/yari/blob/201f6155c973c6864367d0f123f6176f4ccbf38a/kumascript/macros/LearnSidebar.ejs#L1888 ...
That would be a separate PR, to mdn/yari.
I hope this helps!
@@ -91,4 +95,4 @@ Congratulations on finishing this first module. You should now have a good gener | |||
2. [Getting started with CSS](/en-US/docs/Learn/CSS/First_steps/Getting_started) | |||
3. [How CSS is structured](/en-US/docs/Learn/CSS/First_steps/How_CSS_is_structured) | |||
4. [How CSS works](/en-US/docs/Learn/CSS/First_steps/How_CSS_works) | |||
5. [Using your new knowledge](/en-US/docs/Learn/CSS/First_steps/Using_your_new_knowledge) | |||
5. [Styling a biography page](/en-US/docs/Learn/CSS/First_steps/Styling_a_biography_page) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5. [Styling a biography page](/en-US/docs/Learn/CSS/First_steps/Styling_a_biography_page) | |
5. **Styling a biography page** |
(we should not link to the current page)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wbamberg IMO we should fix this with infrastructure. A same page link should be black and unclickable in any case. But these kinds of navigation elements should actually be pushed into the sidebar proper or rendered in place with special handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree. Having spent some time updating the Learning Area recently, the amount of manual work involved for fixing up links and stuff is ridiculous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schalkneethling see ^^^ . Self links are currently OK except that they report a flaw in this case- I believe there is a PR somewhere to say that they should only report a flaw if the value is a redirect. Otherwise the self link should be considered deliberate.
Note that really what should happen is that these move into the sidebar. However really can't do this unless we fix the sidebar problems outlined here mdn/yari#5547 (comment)
@wbamberg Oh, I totally forgot about this 😵 Should be fixed now with the new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this looks good to me. Thank you @glmvc ! If you don't feel comfortable updating the sidebar, let me know and I'll do it. If you would like to update the sidebar, and have any questions about what to do, please feel free to ask 👍 .
@wbamberg I'd like to take a look at it myself and read up a bit on this topic :) Thanks for your offer, appreciate it 👍 If I get completely stuck, I would get back to you - thanks! |
Summary
I'm referring to PR #13704 because I screwed up quite a bit there and couldn't fix the errors.
With this PR everything should work now (I really hope).
I think the mistake was that instead of moving the document at the beginning (before changes in the md files where made), I moved it at the very end....
Motivation
This PR should replace the one mentioned.
Supporting details
PR #13704 & Issue #11932
Related issues
Metadata