Repository navigation
Add a data guideline for HTML constructors - #30349
Merged
Merged
Conversation
Elchi3
added
the
meeting agenda
github-actions
Bot
added
data:api
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
ddbeck
reviewed
Sep 1, 2026
ddbeck
left a comment
ddbeck
left a comment
Contributor
There was a problem hiding this comment.
I'm still mulling over whether this is the right choice, but this is the status quo so we ought to document it (and/or change it if we want a policy change). Some writing suggestions in line comments. Thank you!
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Member
Author
|
I filed issue for future work: |
Merged
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes a guideline to formalize what has been happening all along: HTML elements get no key for their constructors. In the past, probably accidentally, two HTML element constructors have been added for HTMLGeolocation and HTMLOutputElement. This PR removes that data.
Alternative
The alternative is that all HTML element APIs get their constructor key. I believe they only got their constructors when custom elements were introduced, but I might be wrong. Developers don't use HTML element constructors directly. I think they are only meaningful in the context of custom elements. (Docs written at https://developer.mozilla.org/en-US/docs/Web/API/HTMLGeolocationElement/HTMLGeolocationElement are really weak and don't really illustrate any useful usage imho).
Related issues
Unblocks